feat(misc): minor change

thanhtran468 · Jul 9, 2024 · 69d7b18 · 69d7b18
1 parent 8bdd5ef
commit 69d7b18
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/src/Api/UnauthenticatedApi.php b/src/Api/UnauthenticatedApi.php
@@ -29,11 +29,7 @@ public function login(array $credentials): AuthenticatedApi
             ->setAllowedTypes('accessCode', 'string')
         ;
 
-        [$captchaId, $captchaCode] = $this->bypassCaptcha();
-
-        $parameters = $resolver->resolve($credentials);
-        $parameters['captchaId'] = $captchaId;
-        $parameters['captchaCode'] = $captchaCode;
+        $parameters = $resolver->resolve($credentials) + $this->bypassCaptcha();
 
         /** @var array{sessionId: string, ...} */
         $result = $this->post('signIn', $parameters);
@@ -45,15 +41,16 @@ public function login(array $credentials): AuthenticatedApi
     }
 
     /**
-     * @return array{string,string}
+     * @return array{captchaId:string,captchaCode:string}
      */
     private function bypassCaptcha(): array
     {
         $captchaId = Random::generate(9, '0-9a-zA-Z');
         $svg = (string) $this->iPayClient->getClient()
             ->get(sprintf('api/get-captcha/%s', $captchaId))
             ->getBody();
+        $captchaCode = CaptchaSolver::solve($svg);
 
-        return [$captchaId, CaptchaSolver::solve($svg)];
+        return compact('captchaId', 'captchaCode');
     }
 }