Skip to content

Commit

Permalink
Remove app.kubernetes.io/version from Router Deployment Selector Labels
Browse files Browse the repository at this point in the history
  • Loading branch information
michael-burt committed May 2, 2024
1 parent 4863995 commit 76f01d2
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,14 @@ We use *breaking* word for marking changes that are not backward compatible (rel
- [#299](https://github.com/thanos-io/kube-thanos/pull/299) Query: allow configuration of telemetry.request options
- [#301](https://github.com/thanos-io/kube-thanos/pull/301) Receive: allow configuration of `minReadySeconds` for StatefulSet
- [#305](https://github.com/thanos-io/kube-thanos/pull/305) Receive: allow configuration of limits-config-file
- [#308](https://github.com/thanos-io/kube-thanos/pull/308) Recive: add store limits flags
- [#308](https://github.com/thanos-io/kube-thanos/pull/308) Receive: add store limits flags
- [#310](https://github.com/thanos-io/kube-thanos/pull/310) Ruler: Add host anti-affinity to ruler
- [#313](https://github.com/thanos-io/kube-thanos/pull/313) Add per-container SecurityContext

### Fixed

- [#298](https://github.com/thanos-io/kube-thanos/pull/298) Use `kubernetes.io/os` instead of `beta.kubernetes.io/os` which has been deprecated since Kubernetes v1.14.
- [#000](https://github.com/thanos-io/kube-thanos/pull/000) Receive: remove `app.kubernetes.io/version` from Router Deployment Selector Labels


## [v0.27.0](https://github.com/thanos-io/kube-thanos/tree/v0.27.0) (2022-07-07)
Expand Down
8 changes: 7 additions & 1 deletion jsonnet/kube-thanos/kube-thanos-receive-router.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ function(params) {
'app.kubernetes.io/component': tr.config.name + '-router',
},

podLabelSelector:: {
[labelName]: tr.routerLabels[labelName]
for labelName in std.objectFields(tr.routerLabels)
if labelName != 'app.kubernetes.io/version'
},

service: {
apiVersion: 'v1',
kind: 'Service',
Expand Down Expand Up @@ -77,7 +83,7 @@ function(params) {
},
spec: {
replicas: tr.config.routerReplicas,
selector: { matchLabels: tr.routerLabels },
selector: { matchLabels: tr.podLabelSelector },
template: {
metadata: {
labels: tr.routerLabels,
Expand Down
1 change: 0 additions & 1 deletion manifests/thanos-receive-router-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ spec:
app.kubernetes.io/component: thanos-receive-router
app.kubernetes.io/instance: thanos-receive
app.kubernetes.io/name: thanos-receive
app.kubernetes.io/version: v0.31.0
template:
metadata:
labels:
Expand Down

0 comments on commit 76f01d2

Please sign in to comment.