Skip to content

Commit

Permalink
fix #21 and bump to v0.5.10
Browse files Browse the repository at this point in the history
  • Loading branch information
thchr committed Sep 27, 2022
1 parent 4bb8779 commit 7be63e0
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Brillouin"
uuid = "23470ee3-d0df-4052-8b1a-8cbd6363e7f0"
authors = ["Thomas Christensen <[email protected]> and contributors"]
version = "0.5.9"
version = "0.5.10"

[deps]
Bravais = "ada6cbde-b013-4edf-aa94-f6abe8bd6e6b"
Expand Down
11 changes: 10 additions & 1 deletion src/KPaths.jl
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,16 @@ function irrfbz_path(sgnum::Integer, Rs, Dᵛ::Val{D}=Val(3)) where D
D′ = length(Rs)::Int
D′ D && throw(DimensionMismatch("inconsistent dimensions of `Rs` and `Dᵛ`"))
any(R -> length(R)::Int D, Rs) && throw(DimensionMismatch("inconsistent element dimensions in `Rs`"))
Rs = convert(DirectBasis{D}, Rs)::DirectBasis{D}
Rs = convert(DirectBasis{D}, Rs)
@static if VERSION v"1.9.0-DEV.1433"
# for earlier versions of Julia, this could fail due to an internal compiler bug,
# cf. issue #21 and https://github.com/JuliaLang/julia/issues/46871; this was fixed
# in https://github.com/JuliaLang/julia/pull/46882; so only typeassert on Julia
# versions where this is fixed.
# the typeassert is here in order to improve inference for callers of `irrfbz_path`
# where `Rs` is poorly inferred or entirely uninferred (e.g., `typeof(Rs) === Any`)
Rs::DirectBasis{D}
end

# (extended) bravais type
bt = bravaistype(sgnum, D; normalize=false)
Expand Down

2 comments on commit 7be63e0

@thchr
Copy link
Owner Author

@thchr thchr commented on 7be63e0 Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/69059

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.5.10 -m "<description of version>" 7be63e036d28aa789328bf71d31da74a12599dbe
git push origin v0.5.10

Please sign in to comment.