[SL-38] Feat - Show attendee seat data on attendee report page. #3054
Conversation
rafsuntaskin
changed the title
|
|
||
| return $seat_label; | ||
| } | ||
| } |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶PSR2.Files.EndFileNewline.NoneFound
Expected 1 newline at end of file; 0 found
| $layout_id = get_post_meta( $event_id, Meta::META_KEY_LAYOUT_ID, true ); | ||
| update_post_meta( $attendee->ID, Meta::META_KEY_LAYOUT_ID, $layout_id ); | ||
| } | ||
| } |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶PSR2.Files.EndFileNewline.TooMany
Expected 1 blank line at end of file; 2 found
| public function render_seat_column( $value, $item, $column ) { | ||
| return $this->attendee->render_seat_column( $value, $item, $column ); | ||
| } | ||
| } |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶PSR2.Files.EndFileNewline.TooMany
Expected 1 blank line at end of file; 2 found
| * @package TEC/Tickets/Seating/Orders | ||
| */ | ||
| class Controller extends Controller_Contract { | ||
|
|
There was a problem hiding this comment.
Remove this blank space at the beginning, why?!
| * @return void | ||
| */ | ||
| protected function do_register(): void { | ||
| // Todo: This is only handling seating info for TicketsCommerce for now, in future we have to include other actions for other providers. |
There was a problem hiding this comment.
Other commerce providers will be in ET+, though, right? I think this TODO can be removed from here.
| public function add_attendee_seat_column( array $columns, int $event_id ): array { | ||
| $event_layout_id = get_post_meta( $event_id, Meta::META_KEY_LAYOUT_ID, true ); | ||
|
|
||
| if ( empty( $event_layout_id ) && ! tribe( Attendees_Page::class )->is_on_page() ) { |
There was a problem hiding this comment.
This check on the current request being on the Attendee_Page is very late.
If we're not on the Attendee Page, by the time this bailed out, a number of queries and controller routing did happen.
I would move this check on this being the Attendee Page or not in the Controller and, there, hook this callback only if required.
Did you try that? Did it not work?
| add_action( 'tec_tickets_commerce_flag_action_generated_attendee', [ $this, 'save_seat_data_for_attendee' ], 10, 7 ); | ||
|
|
||
| // Add attendee seat data column to the attendee list. | ||
| add_filter( 'tribe_tickets_attendee_table_columns', [ $this, 'add_attendee_seat_column' ], 10, 2 ); |
There was a problem hiding this comment.
As proposed in the Attendee class of this same namespace, I would be curious to know if we could hook these only in the context of the Attendees page.
|
|
||
| namespace TEC\Tickets\Seating\Orders; | ||
|
|
||
| use Illuminate\Support\Str; |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶SlevomatCodingStandard.Namespaces.UnusedUses.UnusedUse
Type Illuminate\Support\Str is not used in this file.
🎫 Ticket
SL-38
🗒️ Description
Unassigned.🎥 Artifacts
🎥 screencast(s): https://www.loom.com/share/17940e6d91ee45a3a82bb72d9f740272
Update 2: https://www.loom.com/share/7b5575199bab42ca983ad2139799aece
✔️ Checklist
readme.txtfile.wpunitorintegrationtests.wpunitorintegrationtests.