Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-148] Layout listing updates #3072

Merged
merged 11 commits into from
Jun 20, 2024
Merged

Conversation

rafsuntaskin
Copy link
Contributor

@rafsuntaskin rafsuntaskin commented Jun 19, 2024

🎫 Ticket

SL-148

🗒️ Description

  • Layout Edit link opens up iframe view to edit the layout.
  • Changed the layout card text “No upcoming events” to “No associated events” when a layout has no associated events of any kind.
  • Count and display the number of associated events when available and hide the delete button.

🎥 Artifacts

📷 screenshot(s): https://share.cleanshot.com/10qqbFBK

✔️ Checklist

  • Changelog entry in the readme.txt file.
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@rafsuntaskin rafsuntaskin self-assigned this Jun 19, 2024
@rafsuntaskin rafsuntaskin added the code review Status: requires a code review. label Jun 19, 2024
@rafsuntaskin rafsuntaskin requested a review from lucatume June 19, 2024 00:20
@rafsuntaskin rafsuntaskin requested a review from lucatume June 19, 2024 20:46
@lucatume lucatume merged commit dcaef9c into feat/slr-support Jun 20, 2024
12 of 15 checks passed
@lucatume lucatume deleted the feat/sl-148-layout-updates branch June 20, 2024 08:36
@rafsuntaskin rafsuntaskin removed the code review Status: requires a code review. label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants