SLR - SL-149 plugin side work #3118

lucatume · 2024-07-19T15:57:46Z

No description provided.

…9-plugin-side

tec-bot

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

event-tickets/src/Tickets/Seating/Orders/Controller.php

Line 412 in 12710e9

->add_to_group( 'tec-tickets-seating' )

[phpcs] _{reported by reviewdog 🐶}
Universal.WhiteSpace.PrecisionAlignment.Found
Found precision alignment of 1 spaces.

event-tickets/src/Tickets/Seating/Orders/Controller.php

Line 413 in 12710e9

->register();

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

event-tickets/src/Tickets/Seating/Orders/Controller.php

Line 413 in 12710e9

->register();

[phpcs] _{reported by reviewdog 🐶}
Universal.WhiteSpace.PrecisionAlignment.Found
Found precision alignment of 1 spaces.

event-tickets/src/Tickets/Seating/Orders/Controller.php

Line 420 in 12710e9

->add_to_group( 'tec-tickets-seating-admin' )

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

event-tickets/src/Tickets/Seating/Orders/Controller.php

Line 420 in 12710e9

->add_to_group( 'tec-tickets-seating-admin' )

[phpcs] _{reported by reviewdog 🐶}
Universal.WhiteSpace.PrecisionAlignment.Found
Found precision alignment of 1 spaces.

event-tickets/src/Tickets/Seating/Orders/Controller.php

Line 421 in 12710e9

->add_to_group( 'tec-tickets-seating' )

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

event-tickets/src/Tickets/Seating/Orders/Controller.php

Line 421 in 12710e9

->add_to_group( 'tec-tickets-seating' )

[phpcs] _{reported by reviewdog 🐶}
Universal.WhiteSpace.PrecisionAlignment.Found
Found precision alignment of 1 spaces.

event-tickets/src/Tickets/Seating/Orders/Controller.php

Line 422 in 12710e9

->enqueue_on( Seats_Report::$asset_action )

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

event-tickets/src/Tickets/Seating/Orders/Controller.php

Line 422 in 12710e9

->enqueue_on( Seats_Report::$asset_action )

[phpcs] _{reported by reviewdog 🐶}
Universal.WhiteSpace.PrecisionAlignment.Found
Found precision alignment of 1 spaces.

event-tickets/src/Tickets/Seating/Orders/Controller.php

Line 423 in 12710e9

->add_to_group( 'tec-tickets-seating-admin' )

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

event-tickets/src/Tickets/Seating/Orders/Controller.php

Line 423 in 12710e9

->add_to_group( 'tec-tickets-seating-admin' )

[phpcs] _{reported by reviewdog 🐶}
Universal.WhiteSpace.PrecisionAlignment.Found
Found precision alignment of 1 spaces.

event-tickets/src/Tickets/Seating/Orders/Controller.php

Line 424 in 12710e9

->register();

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

event-tickets/src/Tickets/Seating/Orders/Controller.php

Line 424 in 12710e9

->register();

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.IncrementDecrementSpacing.SpaceAfterIncrement
Expected no spaces between ] and the increment operator; 1 found

event-tickets/src/Tickets/Seating/Orders/Controller.php

Line 456 in 12710e9

$carry[ $attendee['purchaser_id'] ] ++;

tec-bot · 2024-07-19T15:58:24Z

src/Tickets/Seating/Admin/Ajax.php

-		add_action( 'wp_ajax_' . self::ACTION_INVALIDATE_MAPS_LAYOUTS_CACHE, [ $this, 'invalidate_maps_layouts_cache' ] );
+		$this->register_assets();
+		add_action( 'wp_ajax_' . self::ACTION_GET_SEAT_TYPES_BY_LAYOUT_ID, [ $this, 'fetch_seat_types_by_layout_id' ] );
+		add_action( 'wp_ajax_' . self::ACTION_INVALIDATE_MAPS_LAYOUTS_CACHE,


[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

tec-bot · 2024-07-19T15:58:24Z

src/Tickets/Seating/Admin/Ajax.php

+		$this->register_assets();
+		add_action( 'wp_ajax_' . self::ACTION_GET_SEAT_TYPES_BY_LAYOUT_ID, [ $this, 'fetch_seat_types_by_layout_id' ] );
+		add_action( 'wp_ajax_' . self::ACTION_INVALIDATE_MAPS_LAYOUTS_CACHE,
+			[ $this, 'invalidate_maps_layouts_cache' ] );


[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.Indent
Multi-line function call not indented correctly; expected 8 spaces but found 12

tec-bot · 2024-07-19T15:58:24Z

src/Tickets/Seating/Admin/Ajax.php

+		$this->register_assets();
+		add_action( 'wp_ajax_' . self::ACTION_GET_SEAT_TYPES_BY_LAYOUT_ID, [ $this, 'fetch_seat_types_by_layout_id' ] );
+		add_action( 'wp_ajax_' . self::ACTION_INVALIDATE_MAPS_LAYOUTS_CACHE,
+			[ $this, 'invalidate_maps_layouts_cache' ] );


[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself

tec-bot · 2024-07-19T15:58:24Z

src/Tickets/Seating/Admin/Ajax.php

+			$this->built_asset_url( 'ajax.js' ),
+			Tickets_Main::VERSION
+		)
+		     ->add_localize_script( 'tec.tickets.seating.ajax', [ $this, 'get_ajax_data' ] )


[phpcs] _{reported by reviewdog 🐶}
Universal.WhiteSpace.PrecisionAlignment.Found
Found precision alignment of 1 spaces.

tec-bot · 2024-07-19T15:58:24Z

src/Tickets/Seating/Admin/Ajax.php

+			$this->built_asset_url( 'ajax.js' ),
+			Tickets_Main::VERSION
+		)
+		     ->add_localize_script( 'tec.tickets.seating.ajax', [ $this, 'get_ajax_data' ] )


[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tec-bot · 2024-07-19T15:58:26Z

src/Tickets/Seating/Orders/Controller.php

+		     ->add_localize_script(
+			     'tec.tickets.seating.admin.seatsReport.data',
+			     fn() => $this->get_localized_data( get_the_ID() )
+		     )


[phpcs] _{reported by reviewdog 🐶}
Universal.WhiteSpace.PrecisionAlignment.Found
Found precision alignment of 1 spaces.

tec-bot · 2024-07-19T15:58:26Z

src/Tickets/Seating/Orders/Controller.php

+		     ->add_localize_script(
+			     'tec.tickets.seating.admin.seatsReport.data',
+			     fn() => $this->get_localized_data( get_the_ID() )
+		     )


[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tec-bot · 2024-07-19T15:58:26Z

src/Tickets/Seating/Orders/Controller.php

+			     'tec.tickets.seating.admin.seatsReport.data',
+			     fn() => $this->get_localized_data( get_the_ID() )
+		     )
+		     ->add_to_group( 'tec-tickets-seating-admin' )


[phpcs] _{reported by reviewdog 🐶}
Universal.WhiteSpace.PrecisionAlignment.Found
Found precision alignment of 1 spaces.

tec-bot · 2024-07-19T15:58:26Z

src/Tickets/Seating/Orders/Controller.php

+			     'tec.tickets.seating.admin.seatsReport.data',
+			     fn() => $this->get_localized_data( get_the_ID() )
+		     )
+		     ->add_to_group( 'tec-tickets-seating-admin' )


[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tec-bot · 2024-07-19T15:58:26Z

src/Tickets/Seating/Orders/Controller.php

+			     fn() => $this->get_localized_data( get_the_ID() )
+		     )
+		     ->add_to_group( 'tec-tickets-seating-admin' )
+		     ->add_to_group( 'tec-tickets-seating' )


[phpcs] _{reported by reviewdog 🐶}
Universal.WhiteSpace.PrecisionAlignment.Found
Found precision alignment of 1 spaces.

lucatume added 6 commits July 18, 2024 17:27

refactor(Seating) layout-edit -> layoutEdit

c3c3012

Merge remote-tracking branch 'origin/feat/slr-support' into slr/sl-14…

b5f5e99

…9-plugin-side

style(Seating) udpate

255c8d9

fix(Seating) only count ticketable post types in association

fecacf7

build(Common) track latest feature branch

72c6fa7

WiP - more secure AJAX handler code

12710e9

lucatume self-assigned this Jul 19, 2024

tec-bot reviewed Jul 19, 2024

View reviewed changes

lucatume merged commit 12710e9 into feat/slr-support Jul 22, 2024
12 of 14 checks passed

lucatume deleted the slr/sl-149-plugin-side branch August 1, 2024 09:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SLR - SL-149 plugin side work #3118

SLR - SL-149 plugin side work #3118

lucatume commented Jul 19, 2024

tec-bot left a comment

tec-bot Jul 19, 2024

tec-bot Jul 19, 2024

tec-bot Jul 19, 2024

tec-bot Jul 19, 2024

tec-bot Jul 19, 2024

tec-bot Jul 19, 2024

tec-bot Jul 19, 2024

tec-bot Jul 19, 2024

tec-bot Jul 19, 2024

tec-bot Jul 19, 2024

SLR - SL-149 plugin side work #3118

SLR - SL-149 plugin side work #3118

Conversation

lucatume commented Jul 19, 2024

tec-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment