Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/use group path for seating assets #3381

Merged
merged 27 commits into from
Nov 12, 2024

Conversation

dpanta94
Copy link
Member

@dpanta94 dpanta94 commented Nov 8, 2024

🎫 Ticket

SL-246

🗒️ Description

Affected assets (for QA):

Admin assets

$assets = [
			'tec-tickets-seating-admin-maps'              => '/build/Seating/admin/maps.js',
			'tec-tickets-seating-admin-maps-style'        => '/build/Seating/admin/maps.css',
			'tec-tickets-seating-admin-layouts'           => '/build/Seating/admin/layouts.js',
			'tec-tickets-seating-admin-layouts-style'     => '/build/Seating/admin/layouts.css',
			'tec-tickets-seating-admin-map-edit'          => '/build/Seating/admin/mapEdit.js',
			'tec-tickets-seating-admin-map-edit-style'    => '/build/Seating/admin/mapEdit.css',
			'tec-tickets-seating-admin-layout-edit'       => '/build/Seating/admin/layoutEdit.js',
			'tec-tickets-seating-admin-layout-edit-style' => '/build/Seating/admin/layoutEdit.css',
		];

Utils assets

$assets = [
			'tec-tickets-seating-service-bundle' => '/build/Seating/service.js',
			'tec-tickets-seating-utils'          => '/build/Seating/utils.js',
			'tec-tickets-seating-currency'       => '/build/Seating/currency.js',
		];

Block Editor Assets

$assets = [
			'tec-tickets-seating-block-editor'       => '/build/Seating/blockEditor.js',
			'tec-tickets-seating-block-editor-style' => '/build/Seating/blockEditor.css',
		];

Frontend assets

$assets = [
			'tec-tickets-seating-frontend'       => '/build/Seating/frontend/ticketsBlock.js',
			'tec-tickets-seating-frontend-style' => '/build/Seating/frontend/ticketsBlock.css',
		];

Ajax assets

$assets = [
			'tec-tickets-seating-ajax' => '/build/Seating/ajax.js',
		];

Timer assets

$assets = [
			'tec-tickets-seating-session'       => '/build/Seating/frontend/session.js',
			'tec-tickets-seating-session-style' => '/build/Seating/frontend/session.css',
		];

Order Assets

$assets = [
			'tec-tickets-seating-admin-seats-report'       => '/build/Seating/admin/seatsReport.js',
			'tec-tickets-seating-admin-seats-report-style' => '/build/Seating/admin/seatsReport.css',
		];

🎥 Artifacts

✔️ Checklist

  • Ran npm run changelog to add changelog file(s). More info here
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@dpanta94 dpanta94 force-pushed the feat/use-group-path-for-seating-assets branch from a1afa6d to dc3780e Compare November 8, 2024 14:23
@dpanta94 dpanta94 self-assigned this Nov 8, 2024
@dpanta94 dpanta94 marked this pull request as ready for review November 8, 2024 16:18
Copy link
Contributor

@lucatume lucatume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions about how I think the API could be improved.
Requested some changes about test readability.

tests/slr_integration/Frontend/Timer_Test.php Show resolved Hide resolved
src/Tickets/Seating/Orders/Controller.php Outdated Show resolved Hide resolved
src/Tickets/Seating/Asset_Group_Path.php Outdated Show resolved Hide resolved
Copy link
Contributor

@lucatume lucatume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Asset_Group_Path class could be eliminated.

src/Tickets/Seating/Asset_Group_Path.php Outdated Show resolved Hide resolved
@dpanta94 dpanta94 force-pushed the feat/use-group-path-for-seating-assets branch from 0ee5354 to 0786aff Compare November 12, 2024 12:00
@dpanta94 dpanta94 requested a review from lucatume November 12, 2024 12:03
Copy link
Contributor

@lucatume lucatume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smaller left-over from other feature work

jest.config.js Outdated Show resolved Hide resolved
@dpanta94 dpanta94 merged commit ba6dbc4 into slr/fast-follow-1 Nov 12, 2024
19 of 20 checks passed
@dpanta94 dpanta94 deleted the feat/use-group-path-for-seating-assets branch November 12, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants