-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/use group path for seating assets #3381
Feat/use group path for seating assets #3381
Conversation
a1afa6d
to
dc3780e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some questions about how I think the API could be improved.
Requested some changes about test readability.
836e19f
to
e2ed34d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Asset_Group_Path
class could be eliminated.
0ee5354
to
0786aff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smaller left-over from other feature work
🎫 Ticket
SL-246
🗒️ Description
Affected assets (for QA):
Admin assets
Utils assets
Block Editor Assets
Frontend assets
Ajax assets
Timer assets
Order Assets
🎥 Artifacts
✔️ Checklist
npm run changelog
to add changelog file(s). More info herewpunit
orintegration
tests.wpunit
orintegration
tests.