-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SL-240] - Feat - Create Woo Tickets with Seating. WIP #3481
Open
rafsuntaskin
wants to merge
17
commits into
bucket/woo-seating-integration
Choose a base branch
from
feat/create-woo-seating-tickets
base: bucket/woo-seating-integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[SL-240] - Feat - Create Woo Tickets with Seating. WIP #3481
rafsuntaskin
wants to merge
17
commits into
bucket/woo-seating-integration
from
feat/create-woo-seating-tickets
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafsuntaskin
changed the title
[SL-240] - Feat - Create Woo Tickets with Seating.
[SL-240] - Feat - Create Woo Tickets with Seating. WIP
Jan 13, 2025
rafsuntaskin
commented
Jan 16, 2025
Comment on lines
-361
to
-365
// Bail while in admin side always. There are no reservations in the admin. | ||
if ( is_admin() ) { | ||
return null; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method that is just checking if the reservation data exists. No need to keep it behind admin check.
lucatume
reviewed
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks on spot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π« Ticket
SL-240
ποΈ Description
π₯ Artifacts
π₯ screencast(s): https://share.cleanshot.com/ZvkS0s3c
βοΈ Checklist
npm run changelog
to add changelog file(s). More info herewpunit
orintegration
tests.wpunit
orintegration
tests.