Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-240] - Feat - Create Woo Tickets with Seating. WIP #3481

Open
wants to merge 17 commits into
base: bucket/woo-seating-integration
Choose a base branch
from

Conversation

rafsuntaskin
Copy link
Contributor

@rafsuntaskin rafsuntaskin commented Jan 13, 2025

🎫 Ticket

SL-240

πŸ—’οΈ Description

πŸŽ₯ Artifacts

πŸŽ₯ screencast(s): https://share.cleanshot.com/ZvkS0s3c

βœ”οΈ Checklist

  • Ran npm run changelog to add changelog file(s). More info here
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@rafsuntaskin rafsuntaskin self-assigned this Jan 13, 2025
@rafsuntaskin rafsuntaskin changed the title [SL-240] - Feat - Create Woo Tickets with Seating. [SL-240] - Feat - Create Woo Tickets with Seating. WIP Jan 13, 2025
@rafsuntaskin rafsuntaskin marked this pull request as ready for review January 16, 2025 08:40
Comment on lines -361 to -365
// Bail while in admin side always. There are no reservations in the admin.
if ( is_admin() ) {
return null;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method that is just checking if the reservation data exists. No need to keep it behind admin check.

Copy link
Contributor

@lucatume lucatume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks on spot!

@rafsuntaskin rafsuntaskin requested a review from lucatume January 23, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants