Fix init of TC module #3511
Merged
Fix init of TC module #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
63
to
+65
| $this->container->singleton( Module::class ); | ||
| // We need to init for the registration as a module to take place early. | ||
| $this->container->get( Module::class ); |
There was a problem hiding this comment.
Suggested change
| $this->container->singleton( Module::class ); | |
| // We need to init for the registration as a module to take place early. | |
| $this->container->get( Module::class ); | |
| // We need to init for the registration as a module to take place early. | |
| $this->container->singleton( Module::class, Module::class ); |
There was a problem hiding this comment.
Why ? if the the 2 first arguments are the same this is completely unnecessary. The singleton method already does that.
There was a problem hiding this comment.
Passing as 2nd param loads it immediately.
|
Should the hook to load the module should still be relevant after this change? |
rafsuntaskin
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
ETP-972
🗒️ Description
The commerce module should be initialized as early as possible in order for registrations that happen in the parent's construct to take place as early as possible as well.
This was a singleton already, so nothing should break by registering it asap.
🎥 Artifacts
No point for artifact really. The Module would be initialized whenever it was needed for the first time. Making calls to
Tribe__Tickets__Tickets::modules()unstable and completely dependent on timing.✔️ Checklist
npm run changelogto add changelog file(s). More info herewpunitorintegrationtests.wpunitorintegrationtests.