Skip to content

Commit

Permalink
Resolve CR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
pattihis committed Jun 26, 2024
1 parent 73d2488 commit a34f789
Show file tree
Hide file tree
Showing 13 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion src/admin-views/troubleshooting/common-issues.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<div class="tribe-events-admin-faq__answer">
<?php
$label = '<a href="' . esc_url( $common_issue['link'] ) . '" target="_blank" rel="noopener noreferrer">' . esc_html( $common_issue['link_label'] ) . '</a>';
printf( esc_html( $common_issue['solution'] ), wp_kses_post( $label ) );
printf( esc_html( $common_issue['solution'] ), $label ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
?>
</div>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@
/>
<?php echo esc_html( $message ); ?>
</td>
<td><?php echo wp_kses_post( $notes ); ?></td>
<td><?php echo $notes; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></td>
</tr>
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@
/>
<?php echo esc_html( $message ); ?>
</td>
<td><?php echo wp_kses_post( $notes ); ?></td>
<td><?php echo $notes; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></td>
</tr>
2 changes: 1 addition & 1 deletion src/admin-views/troubleshooting/ea-status/eventbrite.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,5 @@
/>
<?php echo esc_html( $message ); ?>
</td>
<td><?php echo wp_kses_post( $notes ); ?></td>
<td><?php echo $notes; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></td>
</tr>
2 changes: 1 addition & 1 deletion src/admin-views/troubleshooting/ea-status/license-key.php
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,5 @@
/>
<?php echo esc_html( $message ); ?>
</td>
<td><?php echo wp_kses_post( $notes ); ?></td>
<td><?php echo $notes; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></td>
</tr>
2 changes: 1 addition & 1 deletion src/admin-views/troubleshooting/ea-status/meetup.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@
/>
<?php echo esc_html( $message ); ?>
</td>
<td><?php echo wp_kses_post( $notes ); ?></td>
<td><?php echo $notes; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></td>
</tr>
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@
/>
<?php echo esc_html( $message ); ?>
</td>
<td><?php echo wp_kses_post( $notes ); ?></td>
<td><?php echo $notes; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></td>
</tr>
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,5 @@
/>
<?php echo esc_html( $message ); ?>
</td>
<td><?php echo wp_kses_post( $notes ); ?></td>
<td><?php echo $notes; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></td>
</tr>
2 changes: 1 addition & 1 deletion src/admin-views/troubleshooting/event-log.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@
<?php esc_html_e( 'Event log', 'tribe-common' ); ?>
</h3>
<div class="tribe-events-admin__recent-log-filters-select-wrapper">
<?php echo esc_html( $error_log ); ?>
<?php echo $error_log; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>
</div>
</div>
4 changes: 2 additions & 2 deletions src/admin-views/troubleshooting/first-steps.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<?php
$url = '<br /> <a href="https://evnt.is/1apu" target="_blank" rel="noopener noreferrer">' . esc_html__( 'View article', 'tribe-common' ) . '</a>';
/* translators: %s: link to the article */
printf( esc_html__( 'Most issues are caused by conflicts with the theme or other plugins. Follow these steps as a first point of action. %s', 'tribe-common' ), wp_kses_post( $url ) );
printf( esc_html__( 'Most issues are caused by conflicts with the theme or other plugins. Follow these steps as a first point of action. %s', 'tribe-common' ), $url ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
?>
</div>
</div>
Expand All @@ -49,7 +49,7 @@
<?php
$url = '<br /> <a href="https://evnt.is/1aqd" target="_blank" rel="noopener noreferrer">' . esc_html__( 'View article', 'tribe-common' ) . '</a>';
/* translators: %s: link to the article */
printf( esc_html__( 'Providing the details of your calendar plugin and settings (located below) helps our support team troubleshoot an issue faster. %s', 'tribe-common' ), wp_kses_post( $url ) );
printf( esc_html__( 'Providing the details of your calendar plugin and settings (located below) helps our support team troubleshoot an issue faster. %s', 'tribe-common' ), $url ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
?>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions src/admin-views/troubleshooting/notice.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@
? admin_url( 'edit.php?post_type=tribe_events&page=tec-events-help' )
: admin_url( 'admin.php?page=tec-tickets-help' );

$help_link = '<a href="' . esc_url( $url ) . '">' . esc_html__( 'Help page?', 'tribe-common' ) . '</a>';
$help = '<a href="' . esc_url( $url ) . '">' . esc_html__( 'Help page?', 'tribe-common' ) . '</a>';
?>
<div class="tribe-events-admin__troubleshooting-notice">
<div class="tribe-events-admin__troubleshooting-notice_title">
<?php
/* translators: %s: link to the help page */
printf( esc_html__( 'Hey there... did you check out the %s', 'tribe-common' ), wp_kses_post( $help_link ) );
printf( esc_html__( 'Hey there... did you check out the %s', 'tribe-common' ), $help ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
?>
</div>
</div>
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@
<?php esc_html_e( 'Recent template changes', 'tribe-common' ); ?>
</h3>
<div class="tribe-events-admin__recent-template-changes">
<?php echo wp_kses_post( $template_changes ); ?>
<?php echo $template_changes; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>
</div>
2 changes: 1 addition & 1 deletion src/admin-views/troubleshooting/system-information.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
</div>

<div class="tribe-events-admin__system-information-widget">
<?php echo wp_kses_post( $system_info ); ?>
<?php echo $system_info; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>
</div>

<div class="tribe-events-admin__system-information-widget-copy">
Expand Down

0 comments on commit a34f789

Please sign in to comment.