SLR Support #2081
SLR Support #2081
Conversation
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "tribe-common", | |||
| "version": "5.2.7", | |||
| "version": "5.4.0-dev", | |||
| @@ -559,14 +564,14 @@ function tribe_format_currency( $cost, $post_id = null, $currency_symbol = null, | |||
| * | |||
| * @category Events | |||
| * @param string $optionName Name of the option to retrieve. | |||
| * @param string $default Value to return if no such option is found. | |||
| * @param string $default Value to return if no such option is found. | |||
There was a problem hiding this comment.
Can you fix the rest of the docblock spacing, since you started?
stratease
added
the
needs release
src/Tribe/Assets.php
Outdated
| if ( ! empty( $asset->origin_url ) ) { | ||
| $asset->origin_url = trailingslashit( $asset->origin_url ); | ||
| } | ||
| $extension = substr( $file, strrpos( $file, '.' ) + 1 ); |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Generic.Formatting.MultipleStatementAlignment.NotSameWarning
Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space
src/Tribe/Assets.php
Outdated
| $asset->origin_url = trailingslashit( $asset->origin_url ); | ||
| } | ||
| $extension = substr( $file, strrpos( $file, '.' ) + 1 ); | ||
| $plugin_path = ! empty( $origin->plugin_path ) ? $origin->plugin_path : $origin->pluginPath; |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase
Object property "$pluginPath" is not in valid snake_case format, try "$plugin_path"
src/Tribe/Assets.php
Outdated
| $plugin_path = ! empty( $origin->plugin_path ) ? $origin->plugin_path : $origin->pluginPath; | ||
|
|
||
| // Infer the type from the file extension, if not passed. | ||
| $type = empty( $arguments['type'] ) ? $extension : $arguments['type']; |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Generic.Formatting.MultipleStatementAlignment.IncorrectWarning
Equals sign not aligned correctly; expected 1 space but found 3 spaces
lucatume
force-pushed
the
feat/slr-support
branch
from
252a5d7 to
575123f
Compare
src/Tribe/Assets.php
Outdated
| // Try to enqueue the minified version of the file if not debugging scripts or the file is not available. | ||
| if ( ! str_contains( $file, '.min.' ) ) { | ||
| // From `something.js` to `something.min.js`. | ||
| $minified_file = substr( $file, 0, - ( strlen( $extension ) + 1 ) ) . '.min.' . $extension; |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Generic.Formatting.MultipleStatementAlignment.NotSameWarning
Equals sign not aligned with surrounding assignments; expected 4 spaces but found 3 spaces
src/Tribe/Assets.php
Outdated
| $asset->type = 'js'; | ||
| } elseif ( substr( $asset->file, -4, 4 ) === '.css' ) { | ||
| $asset->type = 'css'; | ||
| $extension = substr( $file, strrpos( $file, '.' ) + 1 ); |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Generic.Formatting.MultipleStatementAlignment.IncorrectWarning
Equals sign not aligned correctly; expected 1 space but found 3 spaces
lucatume
force-pushed
the
feat/slr-support
branch
from
3d31bfe to
cbe471b
Compare
…foreinvalid-license Check Uplink before invalid license
SL-142 support work
Show close modal button on twentytwenty with !important
…alth Fix and enrich WP_Send_Json_Mocks
…upsell Bump uplink usage to 2.2.1
Add more generic upsell css
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
phpcs
[phpcs] reported by reviewdog 🐶Squiz.Commenting.FunctionComment.Missing
Missing doc comment for function __callStatic()
[phpcs] reported by reviewdog 🐶Generic.WhiteSpace.ScopeIndent.Incorrect
Line indented incorrectly; expected at least 1 tabs, found 0
[phpcs] reported by reviewdog 🐶Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed
[phpcs] reported by reviewdog 🐶Squiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Expected 1 space before asterisk; 5 found
[phpcs] reported by reviewdog 🐶WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 2 space(s) between "'href'" and double arrow, but found 1.
tribe-common/src/Tribe/Field.php
Line 246 in ca4e341
[phpcs] reported by reviewdog 🐶WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 1 space(s) between "'style'" and double arrow, but found 2.
tribe-common/src/Tribe/Field.php
Line 249 in ca4e341
[phpcs] reported by reviewdog 🐶WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 3 space(s) between "'span'" and double arrow, but found 6.
tribe-common/src/Tribe/Field.php
Line 262 in ca4e341
[phpcs] reported by reviewdog 🐶WordPress.Arrays.ArrayIndentation.CloseBraceNotAligned
Array closer not aligned correctly; expected 20 space(s) but found 38
tribe-common/src/Tribe/Field.php
Line 294 in ca4e341
[phpcs] reported by reviewdog 🐶NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceBeforeArrayCloserMultiLine
Expected a new line before the array closer in a multi line array. Found: no spaces
tribe-common/src/Tribe/Field.php
Line 294 in ca4e341
[phpcs] reported by reviewdog 🐶Generic.Formatting.MultipleStatementAlignment.NotSameWarning
Equals sign not aligned with surrounding assignments; expected 2 spaces but found 6 spaces
tribe-common/src/Tribe/Field.php
Line 474 in ca4e341
[phpcs] reported by reviewdog 🐶Universal.WhiteSpace.DisallowInlineTabs.NonIndentTabsUsed
Spaces must be used for mid-line alignment; tabs are not allowed
tribe-common/src/Tribe/Field.php
Line 477 in ca4e341
[phpcs] reported by reviewdog 🐶Universal.WhiteSpace.DisallowInlineTabs.NonIndentTabsUsed
Spaces must be used for mid-line alignment; tabs are not allowed
tribe-common/src/Tribe/Field.php
Line 484 in ca4e341
[phpcs] reported by reviewdog 🐶Generic.Formatting.MultipleStatementAlignment.NotSameWarning
Equals sign not aligned with surrounding assignments; expected 1 space but found 5 spaces
tribe-common/src/Tribe/Field.php
Line 484 in ca4e341
[phpcs] reported by reviewdog 🐶Squiz.Commenting.BlockComment.NoNewLine
Block comment text must start on a new line
No description provided.