Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined funcs, reference this scope directly instead. #2094

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Undefined funcs, reference this scope directly instead. #2094

merged 1 commit into from
Jun 3, 2024

Conversation

stratease
Copy link
Contributor

@stratease stratease commented Jun 3, 2024 •
edited
Loading

🗒️ Description

This was causing a test failure in ECP. Calling the set_fn_return on $this now.

🎥 Artifacts

image

✔️ Checklist

  • Changelog entry in the readme.txt file.
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@stratease stratease self-assigned this Jun 3, 2024
@stratease stratease requested a review from pattihis June 3, 2024 18:13
@stratease stratease added the code review Status: requires a code review. label Jun 3, 2024
@stratease stratease merged commit ee25fa5 into bucket/plugin-consolidation Jun 3, 2024
11 of 16 checks passed
@stratease stratease deleted the fix/fatal-undefined-func branch June 3, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pattihis pattihis pattihis approved these changes

@dpanta94 dpanta94 dpanta94 approved these changes

Assignees

@stratease stratease

Labels
code review Status: requires a code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stratease @dpanta94 @pattihis