Update Stellar Sale Banner and Logic #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tec-bot
reviewed
Jun 4, 2024
tec-bot
reviewed
Jun 4, 2024
tec-bot
reviewed
Jun 5, 2024
tec-bot
reviewed
Jun 5, 2024
dpanta94
approved these changes
Jun 5, 2024
Comment on lines
+70
to
85
| // Determine the copy based on the active plugins. | ||
| $has_events_calendar_pro = $dependency->is_plugin_active( 'Tribe__Events__Pro__Main' ); | ||
| $has_event_tickets_plus = $dependency->is_plugin_active( 'Tribe__Tickets_Plus__Main' ); | ||
|
|
||
| if ( $has_events_calendar_pro && ! $has_event_tickets_plus ) { | ||
| $template_args['sub_heading'] = __( 'Save 40% on Filter Bar.', 'tribe-common' ); | ||
| $template_args['stellar_copy'] = __( 'Add filters to your calendar during the annual Stellar Sale. Now through July 30.', 'tribe-common' ); | ||
| } elseif ( $has_event_tickets_plus && ! $has_events_calendar_pro ) { | ||
| $template_args['sub_heading'] = __( 'Save 40% on The Events Calendar Bundles.', 'tribe-common' ); | ||
| $template_args['stellar_copy'] = __( 'Take <b>40%</b> off when you upgrade to a bundle during the annual Stellar Sale. Now through July 30.', 'tribe-common' ); | ||
| } else { | ||
| $template_args['heading'] = __( 'Make it stellar.', 'tribe-common' ); | ||
| $template_args['sub_heading'] = __( 'Save 40% on all StellarWP products.', 'tribe-common' ); | ||
| $template_args['stellar_copy'] = __( 'Take <b>40%</b> off all brands during the annual Stellar Sale. Now through July 30.', 'tribe-common' ); | ||
| } | ||
| } |
There was a problem hiding this comment.
Completely optional and up to you. - Could we refactor this whole if - elseif - else to early return instead ?
e.g.
if ( ! $dependency->has_active_premium_plugin() ) {
return $this->get_template()->template( 'notices/tribe-stellar-sale', $template_args, false );
}
if ( $has_events_calendar_pro && $has_event_tickets_plus ) {
// $template_args[]...
return;
}
if ( ! $has_events_calendar_pro ) {
return;
}
// has only ECP
return;
There was a problem hiding this comment.
We don't want to return, because we are passing the template args into the template on line 87.
There was a problem hiding this comment.
We would be returning the template in every scenario, in that case, repeating the same line of code over and over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
ET-2113
🗒️ Description
Updated the banner for the 2024 Stellar Sale.
🎥 Artifacts
✔️ Checklist
readme.txtfile.wpunitorintegrationtests.wpunitorintegrationtests.