EVA-157 Conditional Endpoint Disabling

[pattihis]

🎫 Ticket

EVA-157
EVA-158

🗒️ Description

1. We were checking the dependencies of 'create_events' endpoint only. I added the rest, checking in two groups, for TEC and ET dependant actions. There was also one filter that did not exist any more, about queues, so I adjusted the code there as well.
2. The tooltips were not showing because the assets of EVA were not loading properly after the merge so I've fixed that too.

✔️ Checklist

• Changelog entry in the readme.txt file.
• Code is covered by NEW wpunit or integration tests.
• Code is covered by EXISTING wpunit or integration tests.
• Are all the required tests passing?
• Automated code review comments are addressed.
• Have you added Artifacts?
• Check the base branch for your PR.
• Add your PR to the project board for the release.

[stratease]

We don't need to deprecate the old filter in case of 3rd party usage? cc @jesseeproductions

[codingmusician]

Being that the @since is TBD doesn't that mean this is a new filter. Not in production, yet?

[codingmusician]

Good stuff. A few nit picky things I saw.

[codingmusician]

Nit pick:

Suggested change

	* @param WP_REST_Server $handler ResponseHandler instance (usually WP_REST_Server).
	* @param WP_REST_Request $request Request used to generate the response.
	* @param WP_REST_Server $handler ResponseHandler instance (usually WP_REST_Server).
	* @param WP_REST_Request $request Request used to generate the response.

[codingmusician]

This is super long. It might be better to do this:

Suggested change

	'classes_wrap' => [ 'tec-automator-grid-item', 'tec-settings-connection-endpoint-dashboard-details__name-wrap', ! $endpoint['enabled'] || $endpoint['missing_dependency'] ? 'disabled' : '' ],
	'classes_wrap' => [
	'tec-automator-grid-item',
	'tec-settings-connection-endpoint-dashboard-details__name-wrap',
	! $endpoint['enabled'] || $endpoint['missing_dependency'] ? 'disabled' : '',
	],

[codingmusician]

If we're sending the same args into the template, it might be simpler to store them in a variable to pass them along:

$template_args = [
	'endpoint' => $endpoint,
	'manager'  => $manager,
	'url'      => $url,
];

That way, the template lines are on one line:

$this->template( 'dashboard/components/missing-dependency', $template_args );

[codingmusician]

Same comment here from above about putting the template args into a variable.

[pattihis]

@codingmusician thanks. To give you some context, this is a file from EVA that was merged in Common recently. I did not make these changes; all these additions you see are because of the PHPCS formating to satisfy the @tec-bot review.

I had different commits for my changes and for the code formatting to help the reviewers.

The actual change in this file was at line 97 of the original, where it had a
if ( $endpoint['missing_dependency'] ) {

I moved that higher to also exclude the action buttons from showing. Everything else is from the phpcbf.