Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve sniffer's errors and warning in src/admin-views/ #2124

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Resolve sniffer's errors and warning in src/admin-views/ #2124

merged 5 commits into from
Jul 2, 2024

Conversation

pattihis
Copy link
Contributor

🗒️ Description

Follow-up to this PR to resolve code sniffer's errors and warnings.

✔️ Checklist

  • Changelog entry in the readme.txt file.
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@pattihis pattihis self-assigned this Jun 24, 2024
@pattihis pattihis requested a review from bordoni June 24, 2024 17:25
@pattihis pattihis added the code review Status: requires a code review. label Jun 24, 2024
stratease
stratease previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@stratease stratease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok. Let's get a second approve this is a huge PR, not confident I didn't miss something.

bordoni
bordoni previously approved these changes Jun 25, 2024
View reviewed changes
@bordoni bordoni self-requested a review June 25, 2024 04:19
@bordoni bordoni dismissed their stale review June 25, 2024 04:20

Removing review I need to take a closer look.

bordoni
bordoni requested changes Jun 26, 2024
View reviewed changes
src/admin-views/zapier/dashboard/components/missing-dependency.php Outdated Show resolved Hide resolved
src/admin-views/troubleshooting/system-information.php Outdated Show resolved Hide resolved
src/admin-views/troubleshooting/recent-template-changes.php Outdated Show resolved Hide resolved
src/admin-views/troubleshooting/event-log.php Outdated Show resolved Hide resolved
src/admin-views/dashboard/components/missing-dependency.php Outdated Show resolved Hide resolved
src/admin-views/troubleshooting/ea-status/eventbrite.php Outdated Show resolved Hide resolved
src/admin-views/troubleshooting/ea-status/current-usage.php Outdated Show resolved Hide resolved
src/admin-views/troubleshooting/ea-status/current-status.php Outdated Show resolved Hide resolved
src/admin-views/troubleshooting/common-issues.php Outdated Show resolved Hide resolved
src/admin-views/troubleshooting.php Show resolved Hide resolved
@bordoni bordoni added the enhance Code could use some enhancements before merging. label Jun 26, 2024
@pattihis
Merge branch 'bucket/plugin-consolidation' of github.com:the-events-c…
73d2488 
…alendar/tribe-common into fix/PHPCS-Errors

# Conflicts:
#	src/admin-views/dashboard/components/missing-dependency.php
#	src/admin-views/notices/tribe-stellar-sale.php
#	src/admin-views/zapier/dashboard/components/missing-dependency.php
tec-bot
tec-bot reviewed Jun 26, 2024
View reviewed changes
src/admin-views/troubleshooting/common-issues.php Outdated Show resolved Hide resolved
src/admin-views/troubleshooting/ea-status/current-status.php Outdated Show resolved Hide resolved
src/admin-views/troubleshooting/ea-status/current-usage.php Outdated Show resolved Hide resolved
src/admin-views/troubleshooting/ea-status/eventbrite.php Outdated Show resolved Hide resolved
src/admin-views/troubleshooting/ea-status/license-key.php Outdated Show resolved Hide resolved
src/admin-views/troubleshooting/first-steps.php Outdated Show resolved Hide resolved
src/admin-views/troubleshooting/first-steps.php Outdated Show resolved Hide resolved
src/admin-views/troubleshooting/notice.php Outdated Show resolved Hide resolved
src/admin-views/troubleshooting/recent-template-changes.php Outdated Show resolved Hide resolved
src/admin-views/troubleshooting/system-information.php Outdated Show resolved Hide resolved
@pattihis pattihis requested a review from bordoni June 26, 2024 17:03
bordoni
bordoni previously approved these changes Jun 28, 2024
View reviewed changes
@pattihis pattihis added merge Status: ready to merge. and removed enhance Code could use some enhancements before merging. code review Status: requires a code review. labels Jul 1, 2024
@pattihis pattihis merged commit 2f9c929 into bucket/plugin-consolidation Jul 2, 2024
11 of 16 checks passed
@pattihis pattihis deleted the fix/PHPCS-Errors branch July 2, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tec-bot tec-bot tec-bot left review comments

@bordoni bordoni bordoni approved these changes

@stratease stratease stratease left review comments

Assignees

@pattihis pattihis

Labels
merge Status: ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pattihis @bordoni @stratease @tec-bot