Fix warning about deprecated ability #2333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattihis
changed the title
8 tasks
|
Closed due to branch renaming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
TEC-5086
🗒️ Description
As explained by one of our users here, our
Tribe__PUE__Checker::get_installed_version()function was returningnullbecause it was looking forevent-aggregator/event-aggregator.php. EA is not standalone plugin, it comes bundled with TEC. Passing null to version_compare() in PHP >8.1 caused this warning:Deprecated: version_compare(): Passing null to parameter #2 ($version2) of type string is deprecated in ..\the-events-calendar\common\src\Tribe\PUE\Checker.php on line 1710The fix is to pass an empty string in this case.
🎥 Artifacts
✔️ Checklist
npm run changelogto add changelog file(s). More info herewpunitorintegrationtests.wpunitorintegrationtests.