Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better filtering of buyback items #945

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

Razzmatazzz
Copy link
Member

When showing items to buy and sell back to a trader to increase that trader's spend, we had been filtering weapon presets from the flea because presets show up rarely and cannot be counted on to buy and sell to the traders. Now, in addition to filtering presets, it also filters any items where the last offer count was less than 2. This will further filter out items that aren't reliably on the flea market.

@Razzmatazzz Razzmatazzz requested a review from a team as a code owner June 6, 2024 12:29
Copy link
Contributor

github-actions bot commented Jun 6, 2024

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down summary of our deployment process below:

  1. 👀 Observe the CI jobs and tests to ensure they are passing

  2. ✔️ Obtain an approval/review on this pull request

  3. 🚀 Deploy your pull request to the development environment with .deploy to development

  4. 🚀 Deploy your pull request to the production environment with .deploy

    If anything goes wrong, rollback with .deploy main

  5. 🎉 Merge!

Note: If you have a larger change and want to block deployments, you can run .lock --reason <reason> to lock all other deployments (remove with .unlock)

You can view the branch deploy usage guide for additional information

@Razzmatazzz
Copy link
Member Author

.deploy

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production

You can watch the progress here 🔗

Branch: trader-buyback-enhance

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Deployment Results ✅

Razzmatazzz successfully deployed branch trader-buyback-enhance to production

Environment URL: tarkov.dev

@Razzmatazzz Razzmatazzz merged commit 5fa3b65 into main Jun 6, 2024
2 checks passed
@Razzmatazzz Razzmatazzz deleted the trader-buyback-enhance branch June 6, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants