Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix trader page loading, dynamic trader links #946

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Conversation

Razzmatazzz
Copy link
Member

To do: add Ref trader images.

I think it would also be useful if we could show their barter offers in the list of what they sell at each level.

@Razzmatazzz Razzmatazzz requested a review from a team as a code owner June 6, 2024 21:07
Copy link
Contributor

github-actions bot commented Jun 6, 2024

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down summary of our deployment process below:

  1. 👀 Observe the CI jobs and tests to ensure they are passing

  2. ✔️ Obtain an approval/review on this pull request

  3. 🚀 Deploy your pull request to the development environment with .deploy to development

  4. 🚀 Deploy your pull request to the production environment with .deploy

    If anything goes wrong, rollback with .deploy main

  5. 🎉 Merge!

Note: If you have a larger change and want to block deployments, you can run .lock --reason <reason> to lock all other deployments (remove with .unlock)

You can view the branch deploy usage guide for additional information

@Shebuka
Copy link
Contributor

Shebuka commented Jun 7, 2024

.deploy

Copy link
Contributor

github-actions bot commented Jun 7, 2024

⚠️ Cannot claim deployment lock

Sorry Shebuka, the production environment deployment lock is currently claimed by Razzmatazzz

Lock Details 🔒

  • Environment: production
  • Branch: 93bda6414a99253ffd8b507304d26bccd7de8f05
  • Created At: 2024-06-04T02:17:01.573Z
  • Created By: Razzmatazzz
  • Sticky: true
  • Global: false
  • Comment Link: click here
  • Lock Link: click here

The current lock has been active for 3d:6h:14m:37s

If you need to release the lock, please comment .unlock production

@Shebuka
Copy link
Contributor

Shebuka commented Jun 7, 2024

.unlock production

@Shebuka
Copy link
Contributor

Shebuka commented Jun 7, 2024

.deploy

Copy link
Contributor

github-actions bot commented Jun 7, 2024

🔓 Deployment Lock Removed

The production deployment lock has been successfully removed

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Deployment Triggered 🚀

Shebuka, started a branch deployment to production

You can watch the progress here 🔗

Branch: trader-loading

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Deployment Results ✅

Shebuka successfully deployed branch trader-loading to production

Environment URL: tarkov.dev

@Shebuka
Copy link
Contributor

Shebuka commented Jun 7, 2024

.deploy

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Deployment Triggered 🚀

Shebuka, started a branch deployment to production

You can watch the progress here 🔗

Branch: trader-loading

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Deployment Results ✅

Shebuka successfully deployed branch trader-loading to production

Environment URL: tarkov.dev

@Shebuka Shebuka merged commit f48c232 into main Jun 7, 2024
2 checks passed
@Shebuka Shebuka deleted the trader-loading branch June 7, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants