Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Interchange bounds and GP Coin barters #954

Merged
merged 9 commits into from
Jun 24, 2024
Merged

Conversation

Shebuka
Copy link
Contributor

@Shebuka Shebuka commented Jun 19, 2024

  • Fix sort for costItem when comparing two GP Coin as costs;
  • More consistent sort for instaProfit with secondary sort for savings;
  • Using normalizedName to filter out dogtags;
  • If we have an ammo container let's look inside to calculate the reward item value;
  • Calculating the GP Coin value based on the reward item value;
  • Allow item cost to have no vendor;
  • Fixing getCheapestCashPrice to be able to get 'none' when you can't sell item to anyone;
  • Better Interchange svg bounds;

Sort the barter table by Cost to see the most valued barter per GP Coin

Screenshot 2024-06-19 at 19 14 44

More consistent sort for instaProfit with secondary sort for savings;
Using normalizedName to filter out dogtags;
If we have an ammo container let's look inside to calculate the reward item value;
Calculating the GP Coin value based on the reward item value;
@Shebuka Shebuka requested a review from a team as a code owner June 19, 2024 17:16
Copy link
Contributor

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down summary of our deployment process below:

  1. 👀 Observe the CI jobs and tests to ensure they are passing

  2. ✔️ Obtain an approval/review on this pull request

  3. 🚀 Deploy your pull request to the development environment with .deploy to development

  4. 🚀 Deploy your pull request to the production environment with .deploy

    If anything goes wrong, rollback with .deploy main

  5. 🎉 Merge!

Note: If you have a larger change and want to block deployments, you can run .lock --reason <reason> to lock all other deployments (remove with .unlock)

You can view the branch deploy usage guide for additional information

@Razzmatazzz
Copy link
Member

.deploy

Copy link
Contributor

⚠️ Cannot claim deployment lock

Sorry Razzmatazzz, the production environment deployment lock is currently claimed by Shebuka

Lock Details 🔒

  • Environment: production
  • Branch: 0e8adc371bb82e1cf47af7c5f00bb15db3a0b862
  • Created At: 2024-06-18T08:34:23.290Z
  • Created By: Shebuka
  • Sticky: true
  • Global: false
  • Comment Link: click here
  • Lock Link: click here

The current lock has been active for 1d:11h:49m:38s

If you need to release the lock, please comment .unlock production

@Razzmatazzz
Copy link
Member

.unlock production

Copy link
Contributor

🔓 Deployment Lock Removed

The production deployment lock has been successfully removed

@Razzmatazzz
Copy link
Member

.deploy

Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production

You can watch the progress here 🔗

Branch: feature/mix_fixes

Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch feature/mix_fixes to production

Environment URL: tarkov.dev

@Shebuka
Copy link
Contributor Author

Shebuka commented Jun 19, 2024

.unlock production

@Shebuka
Copy link
Contributor Author

Shebuka commented Jun 19, 2024

.deploy

Copy link
Contributor

🔓 Deployment Lock Removed

The production deployment lock has been successfully removed

Copy link
Contributor

Deployment Triggered 🚀

Shebuka, started a branch deployment to production

You can watch the progress here 🔗

Branch: feature/mix_fixes

Copy link
Contributor

Deployment Results ❌

Shebuka had a failure when deploying branch feature/mix_fixes to production

@Shebuka
Copy link
Contributor Author

Shebuka commented Jun 19, 2024

.deploy

Copy link
Contributor

Deployment Triggered 🚀

Shebuka, started a branch deployment to production

You can watch the progress here 🔗

Branch: feature/mix_fixes

Copy link
Contributor

Deployment Results ✅

Shebuka successfully deployed branch feature/mix_fixes to production

Environment URL: tarkov.dev

@Shebuka Shebuka merged commit 528c742 into main Jun 24, 2024
2 checks passed
@Shebuka Shebuka deleted the feature/mix_fixes branch June 24, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants