-
Notifications
You must be signed in to change notification settings - Fork 503
Upgrade Docker image to Alpine 3.11 #612
Upgrade Docker image to Alpine 3.11 #612
Conversation
Travis failure seem to be unrelated to my changes. They originate from the sphinx documentation :/ |
@languitar @bauerj Merge PR #601 first to fix this issue
Had to add the protocol to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to upgrade Alpine in order to fix issues with tesseract
. I have no complaints merging your changes. Generally, it would be nice to separate changes that are not part of the main PR feature in its own commit.
- Conducted tests
docker-compose build
works- All unit-tests still succeed
- PDF documents are processed
- OCR output looks fine
Maybe I found something:
- After the first
docker-compose up
, I addedPAPERLESS_OCR_LANGUAGES=deu
andPAPERLESS_OCR_LANGUAGE=deu
to both containers. The log of theconsumer
shows me:
sudo: setrlimit(RLIMIT_CORE): Operation not permitted
Operations to perform:
Apply all migrations: admin, auth, contenttypes, documents, reminders, sessions
Running migrations:
No migrations to apply.
fetch http://dl-cdn.alpinelinux.org/alpine/v3.11/main/x86_64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.11/community/x86_64/APKINDEX.tar.gz
(1/1) Installing tesseract-ocr-data-deu (4.1.0-r0)
OK: 308 MiB in 128 packages
sudo: setrlimit(RLIMIT_CORE): Operation not permitted
@languitar thanks for the PR, dependency updates are always nice! #601 is just missing another review from @the-paperless-project/reviewers, then you can rebase on master to fix the Travis issue. Regarding the Feel free to ping me directly for a review once the Travis build is fixed. 👍 |
022f3bb
to
a3d32a3
Compare
I have rebased the PR, added the setrlimit fix, and split the PR into two distinct commits with further clarifications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the major dependency updates as best I could and didn‘t find any incompatibilities that should affect us (besides the already fixed CORS whitelist).
Not all dependencies work well on Alpine 3.11. Thus, bump dependencies and lock again. Due to also updating the CORS packages while dependency locking, the CORS_ORIGIN_WHITELIST had to be changed to valid URIs, which are now required by the respective packages.
This make tesseract 4.1 avaialbe, which fixes some things like infinite processing loops on some documents: tesseract-ocr/tesseract#2288
This make tesseract 4.1 avaialbe, which fixes some things like infinite
processing loops on some documents:
tesseract-ocr/tesseract#2288 (comment)
Some dependencies had to be bumped for being compatible with the new Alpine
libraries.