Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export StandaloneLambdaResponseBody type and constructors #109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tysonzero
Copy link

Closes #108

@dnikolovv
Copy link
Contributor

Hey, I'm not sure whether this should be done. Does the newer way of setting up lambdas not work for your usecase? It's simpler now, you don't need to construct the StandaloneLambdaResponse.

I'll come up with a more detailed response next week, perhaps even improve the docs.

@NickSeagull
Copy link
Member

I thought it was needed for returning the appropriate type, so I pointed him to it, my bad! Looking forward for your response @dnikolovv

@dnikolovv
Copy link
Contributor

Is this helpful?

https://theam.github.io/aws-lambda-haskell-runtime/02-adding-a-handler.html

This + the next section is how you define and then register a handler.

@tysonzero
Copy link
Author

In that case is LambdaResult just deprecated entirely? Given that only two of its three constructors can actually be created.

I'm not totally against refactoring the code later, but right now I'm upgrading a lot of packages at once so just trying to put in the least effort possible for each one.

@dnikolovv
Copy link
Contributor

Yes, it's now deprecated. I guess you can try pinning to the version that works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StandaloneLambdaResponseBody seems impossible to construct
3 participants