Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Pinecone connector #10

Merged
merged 8 commits into from
Jul 26, 2023
Merged

Feature: Pinecone connector #10

merged 8 commits into from
Jul 26, 2023

Conversation

BorjaZarco
Copy link
Contributor

Added a Pinecone connector. For this, the following changes were made:

  • Added a pinecone_client.py, implementing the EmbeddingsStore functions for Pincecone
  • Added pinecone-client dependency to connect to python
  • Added PINECONE .env variables required to connect on python
  • Added docs on to use Pinecone Connector

(Extra)

  • Ignore chroma sqlite db
  • Added launch.json to debug python application

@BorjaZarco BorjaZarco self-assigned this Jul 26, 2023
doramasma
doramasma approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@doramasma doramasma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@BorjaZarco BorjaZarco merged commit 48b2ca9 into main Jul 26, 2023
1 check passed
@BorjaZarco BorjaZarco deleted the feature/pinecone-connector branch July 26, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian-lorenzo adrian-lorenzo adrian-lorenzo approved these changes

@doramasma doramasma doramasma approved these changes

@juanjoman juanjoman Awaiting requested review from juanjoman

Assignees

@BorjaZarco BorjaZarco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BorjaZarco @doramasma @adrian-lorenzo