Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdks): use v15.1.0 of underlying SDKs #339

Closed
wants to merge 1 commit into from

Conversation

mikehardy
Copy link
Collaborator

Just a bump to underlying SDKs, proposed via web UI with no testing, just to see how it goes. If it builds I'll release it

@mikehardy mikehardy added pending-merge Just waiting on clean CI test run. Any maintainer should feel free to merge if CI is passing. and removed pending-merge Just waiting on clean CI test run. Any maintainer should feel free to merge if CI is passing. labels Nov 1, 2022
@mikehardy
Copy link
Collaborator Author

Nope!

facebook/facebook-ios-sdk@347feee

/Users/runner/work/react-native-fbsdk-next/react-native-fbsdk-next/RNFBSDKExample/node_modules/react-native-fbsdk-next/ios/RCTFBSDK/core/RCTFBSDKAEMReporter.m:10:9: fatal error: 'FBAEMKit/FBAEMReporter.h' file not found

https://github.com/thebergamo/react-native-fbsdk-next/actions/runs/3373151633/jobs/5597402817#step:13:5848

I suppose we need to change it to -Swift.h or similar 🤔

@mikehardy
Copy link
Collaborator Author

I begged for help upstream, tracking here facebook/facebook-ios-sdk#2140 🙏

@stale
Copy link

stale bot commented Dec 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 2, 2022
@stale stale bot closed this Dec 9, 2022
@mikehardy mikehardy removed the wontfix This will not be worked on label Mar 20, 2023
@mikehardy mikehardy reopened this Mar 20, 2023
@mikehardy
Copy link
Collaborator Author

Looks like v16 is out? Not sure if it works, needs motivated person to test the update, forward-port https://github.com/facebook/facebook-ios-sdk/releases

@kanadikirik
Copy link

Looks like v16 is out? Not sure if it works, needs motivated person to test the update, forward-port https://github.com/facebook/facebook-ios-sdk/releases

@mikehardy I have upgraded the FBSDKVersion to 16.0.0 in react-native-fbsdk-next.podspec and then I have followed the below solution to fix the issues:

  1. Add #import <FBSDKCoreKit/FBSDKCoreKit.h> into RCTFBSDKAEMReporter.m file instead of #import <FBAEMKit/FBAEMReporter.h>
  2. Add the following lines into the AppDelegate.mm file before #import <FBSDKCoreKit/FBSDKCoreKit-swift.h> line
#import <AuthenticationServices/AuthenticationServices.h>
#import <SafariServices/SafariServices.h>

I'm not sure this is the best solution. However, I can build my own project without issues.

@mikehardy
Copy link
Collaborator Author

Looks like v16 is out? Not sure if it works, needs motivated person to test the update, forward-port https://github.com/facebook/facebook-ios-sdk/releases

@mikehardy I have upgraded the FBSDKVersion to 16.0.0 in react-native-fbsdk-next.podspec and then I have followed the below solution to fix the issues:

  1. Add #import <FBSDKCoreKit/FBSDKCoreKit.h> into RCTFBSDKAEMReporter.m file instead of #import <FBAEMKit/FBAEMReporter.h>
  2. Add the following lines into the AppDelegate.mm file before #import <FBSDKCoreKit/FBSDKCoreKit-swift.h> line
#import <AuthenticationServices/AuthenticationServices.h>
#import <SafariServices/SafariServices.h>

I'm not sure this is the best solution. However, I can build my own project without issues.

That's fantastic! Please post it as a PR and if it works me/others we can merge it and get current. That would be a great achievement

@devops35
Copy link

devops35 commented Apr 6, 2023

Looks like v16 is out? Not sure if it works, needs motivated person to test the update, forward-port https://github.com/facebook/facebook-ios-sdk/releases

@mikehardy I have upgraded the FBSDKVersion to 16.0.0 in react-native-fbsdk-next.podspec and then I have followed the below solution to fix the issues:

  1. Add #import <FBSDKCoreKit/FBSDKCoreKit.h> into RCTFBSDKAEMReporter.m file instead of #import <FBAEMKit/FBAEMReporter.h>
  2. Add the following lines into the AppDelegate.mm file before #import <FBSDKCoreKit/FBSDKCoreKit-swift.h> line
#import <AuthenticationServices/AuthenticationServices.h>
#import <SafariServices/SafariServices.h>

I'm not sure this is the best solution. However, I can build my own project without issues.

@kanadikirik thanks. This is working. But fbaemkit is not working. I get "'FBAEMKit/FBAEMKit.h' file not found" error when I import. How can I resolve this error?
@mikehardy

if I remove #import <FBAEMKit/FBAEMKit.h>, [FBAEMReporter handleURL:url] in application:openurl:options; It gives the error "No known class method for selector 'handleURL:'" on the line.

It was fixed when I replaced handleUrl with handle. It's working fine now. Thanks.

@kesha-antonov
Copy link
Contributor

Looks like v16 is out? Not sure if it works, needs motivated person to test the update, forward-port https://github.com/facebook/facebook-ios-sdk/releases

@mikehardy I have upgraded the FBSDKVersion to 16.0.0 in react-native-fbsdk-next.podspec and then I have followed the below solution to fix the issues:

  1. Add #import <FBSDKCoreKit/FBSDKCoreKit.h> into RCTFBSDKAEMReporter.m file instead of #import <FBAEMKit/FBAEMReporter.h>
  2. Add the following lines into the AppDelegate.mm file before #import <FBSDKCoreKit/FBSDKCoreKit-swift.h> line
#import <AuthenticationServices/AuthenticationServices.h>
#import <SafariServices/SafariServices.h>

I'm not sure this is the best solution. However, I can build my own project without issues.

@kanadikirik thanks. This is working. But fbaemkit is not working. I get "'FBAEMKit/FBAEMKit.h' file not found" error when I import. How can I resolve this error? @mikehardy

if I remove #import <FBAEMKit/FBAEMKit.h>, [FBAEMReporter handleURL:url] in application:openurl:options; It gives the error "No known class method for selector 'handleURL:'" on the line.

It was fixed when I replaced handleUrl with handle. It's working fine now. Thanks.

I guess we need to use

#import <FBAEMKit/FBAEMKit-Swift.h>

[FBAEMReporter configureWithNetworker:nil appID:@"123" reporter:nil]; // Replace {app-id} with your Facebook App id
[FBAEMReporter enable];
[FBAEMReporter handle:url];

@stale
Copy link

stale bot commented May 19, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 19, 2023
@stale stale bot closed this May 31, 2023
@mikehardy mikehardy deleted the @mikehardy/sdk-v15.1.0 branch August 18, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants