Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdks): upgrade to fb-sdk-16 #408

Closed

Conversation

Vincent-liuwingsang
Copy link

update FBSDKVersion to 16

@Vincent-liuwingsang Vincent-liuwingsang changed the title upgrade to fb-sdk-16 feat(sdks): use v16.0.0 of underlying facebook SDKs Apr 6, 2023
@Vincent-liuwingsang Vincent-liuwingsang changed the title feat(sdks): use v16.0.0 of underlying facebook SDKs feat(sdks): pgrade to fb-sdk-16 Apr 6, 2023
@Vincent-liuwingsang Vincent-liuwingsang changed the title feat(sdks): pgrade to fb-sdk-16 feat(sdks): upgrade to fb-sdk-16 Apr 6, 2023
@kesha-antonov
Copy link
Contributor

Waiting to get merged, we've received notification - fb wants sdk upgrade

@kesha-antonov
Copy link
Contributor

Screenshot 2023-04-19 at 23 47 00

When I try to build this fork I get this error

@kesha-antonov
Copy link
Contributor

Related issue

facebook/facebook-ios-sdk#2140

@@ -7,7 +7,7 @@

#import <React/RCTBridgeModule.h>
#import <React/RCTUtils.h>
#import <FBAEMKit/FBAEMReporter.h>
#import <FBSDKCoreKit/FBSDKCoreKit.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it should be #import <FBAEMKit/FBAEMKit-Swift.h>

@zdnk
Copy link

zdnk commented May 7, 2023

any update on this?

@stale
Copy link

stale bot commented Jun 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 8, 2023
@stale stale bot closed this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants