Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algae feeler #130

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Algae feeler #130

wants to merge 9 commits into from

Conversation

CalvinOdropbear
Copy link
Contributor

No description provided.

@james-ward
Copy link
Contributor

I think we should try to use the set() method on the Servo object, rather than setAngle()

This works in the Vision class, so let's stick with what we know works.

@DannyPomeranian DannyPomeranian marked this pull request as ready for review January 30, 2025 08:53
Copy link
Contributor

@james-ward james-ward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code with the initial speed up was not tested on the robot so needs testing again tomorrow.

Put all the angles in degrees. You aren't doing maths with them, and there are just too many calls to math.radians then math.degrees when you want to use the value in a function. This does not contradict Lucien's rule that we always use radians. You aren't measuring this angle - we are just using arbitrary units to scale our values, so it might as well be human readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants