Compensate for turret position when looking for clusters #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks right to me because you're just shifting one side of the line you draw to the camera base. I will sim and check a little more ahead of time after work, but tentatively LGTM |
I messed around by setting the transform of the camera to really offset values and rotations, and by limiting the motion of the servo. Then you can see it is now pointing in the right direction. Single tags are a good way to verify this with the big offsets because it is very obvious. |
|
Closes #125 |
CalvinOdropbear
approved these changes
Jan 28, 2025
LucienMorey
force-pushed
the
camera_pos_compensation
branch
from
f1433a1 to
4e2a518
Compare
LucienMorey
approved these changes
Feb 1, 2025
|
Tested on robot and things seem to be all clear |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.