Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate installing yggdrasil from EPEL #3270

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maximiliankolb
Copy link
Contributor

What changes are you introducing?

Mitigate issue on hosts with EPEL enabled when installing REX pull client.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

If you install the pull provider for remote execution from Foreman Clients on hosts running AlmaLinux, Amazon Linux, CentOS, Oracle Linux, Red Hat Enterprise Linux, or Rocky Linux, you install the yggdrasil package. Because EPEL also contains a package called “yggdrasil”, you have to ensure that the package comes from the Foreman Client and not EPEL in case it is enabled on your host.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

This is a verified solution from ATIX Service Portal.

Another alternative solution is to use dnf --disablerepo="_My_EPEL_Repository_" install yggdrasil.

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • We do not accept PRs for Foreman older than 3.5.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further context: theforeman/foreman_ygg_worker#21 is working on supporting yggdrasil 0.4.

I indeed see it's in EPEL 8 & 9: https://src.fedoraproject.org/rpms/yggdrasil

Probably better to add excludepkgs=yggdrasil in epel.repo. If you have synced content views, you can exclude it there.

Though yggdrasil 0.4.2 is also in CentOS Stream 9 now, so there you have a similar problem. I wonder if we should set a more narrow version dependency in foreman_ygg_worker. Let's have that discussion in theforeman/foreman-packaging#11232.

cc @evgeni @adamruzicka

If you install the pull provider for remote execution from Foreman
Clients on hosts running AlmaLinux, Amazon Linux, CentOS, Oracle Linux,
Red Hat Enterprise Linux, or Rocky Linux, you install the yggdrasil
package. Because EPEL also contains a package called “yggdrasil”,
you have to ensure that the package comes from the Foreman Client and
not EPEL in case it is enabled on your host.
@maximiliankolb maximiliankolb added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective labels Sep 13, 2024
Copy link
Member

@asteflova asteflova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good style-wise.

@maximiliankolb maximiliankolb added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Sep 13, 2024
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer a technical solution to it. As you can see in theforeman/foreman-packaging#11232 (comment) it's possible to properly enforce the requirement. Right now that's waiting on final approval and cherry picking.

@pr-processor pr-processor bot added the Waiting on contributor Requires an action from the author label Sep 13, 2024
@maximiliankolb
Copy link
Contributor Author

@ekohl Should I reopen this PR against 3.11 or the newest version that does not receive a backport? I can even make it non-Satellite and/or non-orcharhino for versions that receive backported bugfixes.

@ekohl
Copy link
Member

ekohl commented Sep 13, 2024

I intend to backport it to 3.10 (oldest supported version). I'll check internally about Satellite

@maximiliankolb maximiliankolb removed the Waiting on contributor Requires an action from the author label Sep 13, 2024
@maximiliankolb
Copy link
Contributor Author

@ekohl Is that PR still needed for Foreman nightly? I saw that theforeman/foreman-packaging#11232 had been merged.

@ekohl
Copy link
Member

ekohl commented Nov 8, 2024

@adamruzicka any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs tech review Requires a review from the technical perspective style review done No issues from docs style/grammar perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants