Allow tabs for container-based builds #3279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximiliankolb
added
Needs tech review
9 tasks
|
The PR preview for 4ff6725 is available at theforeman-foreman-documentation-preview-pr-3279.surge.sh The following output files are affected by this PR: |
ekohl
reviewed
Sep 12, 2024
maximiliankolb
force-pushed
the
container_image_tabs
branch
from
6c9947f
to
179efc6
Compare
ekohl
approved these changes
Sep 13, 2024
maximiliankolb
force-pushed
the
container_image_tabs
branch
from
179efc6
to
f77d18a
Compare
ekohl
reviewed
Sep 13, 2024
* Gem versions follow GHA in foreman-documentation for PR 3104 that introduces tabs which require "asciidoctor-tabs". * Install bundler as RPM.
maximiliankolb
force-pushed
the
container_image_tabs
branch
from
f77d18a
to
4ff6725
Compare
|
Successfully rebuilt with |
maximiliankolb
added
tech review done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gem versions follow GHA in foreman-documentation for PR 3104 that introduces tabs which require "asciidoctor-tabs".
What changes are you introducing?
add "asciidoctor-tabs" to container image.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
prerequisite to testing #3104 locally
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
I have tested removing "rubygem-asciidoctor" as RPM without success. even if it's not perfect, it works as is.
Checklists
Please cherry-pick my commits into: