Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EL9 to "register host without Puppet" #3284

Closed
wants to merge 2 commits into from
Closed

Add EL9 to "register host without Puppet" #3284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b15feee
Add cmd to register host without Puppet on EL9
maximiliankolb Sep 17, 2024
7b18ce0
Name latest version first in list of EL
maximiliankolb Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions guides/common/modules/proc_registering-a-host-without-puppet.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ By default, the bootstrap script configures the host for content management and
If you have an existing configuration management system and do not want to install Puppet on the host, use `--skip-puppet`.

.Procedure
* On {EL} 8, enter the following command:
* On {EL} 9 or 8, enter the following command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a stylistic reason for using "9 or 8" instead of "8 or 9"?

Copy link
Contributor

@Lennonka Lennonka Oct 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tend to list versions from latest to oldest and try to keep it consistent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you list from latest to oldest?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISG does not provide a specific guideline about version order but they list versions from earlier to later in their examples. See References to multiple releases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* On {EL} 9 or 8, enter the following command:
* Enter the following command according to your operating system:
** {EL} 8 or 9:

I recommend you turn this into a single step with 2 bullet points because a procedure with 2 bullets looks like an error.

+
[options="nowrap", subs="+quotes,verbatim,attributes"]
----
Expand All @@ -18,7 +18,7 @@ If you have an existing configuration management system and do not want to insta
--activationkey="_My_Activation_Key_" \
--skip-puppet
----
* On {EL} 6 or 7, enter the following command:
* On {EL} 7 or 6, enter the following command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* On {EL} 7 or 6, enter the following command:
** {EL} 6 or 7:

+
[options="nowrap", subs="+quotes,verbatim,attributes"]
----
Expand Down