Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support puppet 8 #3285

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Support puppet 8 #3285

merged 3 commits into from
Oct 8, 2024

Conversation

maximiliankolb
Copy link
Contributor

What changes are you introducing?

Declare offical support for Puppet 8 to configure hosts.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Foreman 3.12 supports Puppet 8: source: release notes

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

  • Partially untested; instructions are based on steps for Puppet 7.
  • Do we want to make a recommendation to use Puppet 8?

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • We do not accept PRs for Foreman older than 3.5.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

The PR preview for b1e00f8 is available at theforeman-foreman-documentation-preview-pr-3285.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

Lennonka
Lennonka reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@Lennonka Lennonka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these updates!
Overally looks good, but I didn't test anything.

...es/common/modules/proc_installing-and-configuring-puppet-agent-during-host-registration.adoc Show resolved Hide resolved
guides/common/modules/ref_supported-puppet-versions-and-system-requirements.adoc Outdated Show resolved Hide resolved
@Lennonka Lennonka added the Waiting on contributor Requires an action from the author label Sep 23, 2024
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Oct 2, 2024
maximiliankolb
maximiliankolb commented Oct 2, 2024
View reviewed changes
Copy link
Contributor Author

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased to "master".

...es/common/modules/proc_installing-and-configuring-puppet-agent-during-host-registration.adoc Show resolved Hide resolved
guides/common/modules/ref_supported-puppet-versions-and-system-requirements.adoc Outdated Show resolved Hide resolved
@maximiliankolb maximiliankolb added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective labels Oct 2, 2024
maximiliankolb
maximiliankolb commented Oct 4, 2024
View reviewed changes
Copy link
Contributor Author

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased to "master" and applied Lena's feedback.

...es/common/modules/proc_installing-and-configuring-puppet-agent-during-host-registration.adoc Show resolved Hide resolved
guides/common/modules/ref_supported-puppet-versions-and-system-requirements.adoc Outdated Show resolved Hide resolved
maximiliankolb
maximiliankolb commented Oct 7, 2024
View reviewed changes
Copy link
Contributor Author

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased to "master" and split the requirements for Satellite and non-Satellite builds.

guides/common/modules/ref_supported-puppet-versions-and-system-requirements.adoc Show resolved Hide resolved
Lennonka
Lennonka approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! LGTM

@maximiliankolb maximiliankolb added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Oct 8, 2024
Manisha15
Manisha15 approved these changes Oct 8, 2024
View reviewed changes
Copy link

@Manisha15 Manisha15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@maximiliankolb maximiliankolb added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective labels Oct 8, 2024
@maximiliankolb maximiliankolb merged commit 1d4cd6e into theforeman:master Oct 8, 2024
9 checks passed
@maximiliankolb maximiliankolb deleted the support_puppet_8 branch October 8, 2024 07:41
@maximiliankolb
Copy link
Contributor Author

Merged to "master" and cherry-picked:
1f88c99..0bc035b 3.12 -> 3.12

ekohl
ekohl reviewed Oct 8, 2024
View reviewed changes
...es/common/modules/proc_installing-and-configuring-puppet-agent-during-host-registration.adoc
Add a host parameter named `enable-official-puppet7-repo`, select the *boolean* type, and set the value to `true`.
ifdef::katello,orcharhino[]
+
* To use Puppet 8, add a host parameter named `enable-puppet8`, select the *boolean* type, and set the value to `true`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole parameter enable-puppet8 doesn't exist within Foreman. This is IMHO a bug so I opened https://projects.theforeman.org/issues/37891 to track this.

At this point we should really change the implementation to be version independent. It's really AIO packaging vs non-AIO. I'd even argue that these days the AIO packaging is more common and we should default to it.

...es/common/modules/proc_installing-and-configuring-puppet-agent-during-host-registration.adoc
endif::[]
ifdef::foreman-el,foreman-deb[]
+
To use Puppet 8, add a host parameter named `enable-official-puppet8-repo`, select the *boolean* type, and set the value to `true`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for completeness: this parameter does exist since theforeman/foreman@c35092b

@maximiliankolb
Copy link
Contributor Author

Thank you Ewoud for spotting my error and opening the issue. Please ping me if I can make any adjustments to the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@Lennonka Lennonka Lennonka approved these changes

@Manisha15 Manisha15 Manisha15 approved these changes

Assignees
No one assigned
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximiliankolb @ekohl @Manisha15 @Lennonka