Update output of hammer ping #3340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR preview for 216e048 is available at theforeman-foreman-documentation-preview-pr-3340.surge.sh The following output files are affected by this PR: |
maximiliankolb
approved these changes
Oct 2, 2024
maximiliankolb
added
tech review done
asteflova
force-pushed
the
SAT-28362_update_hammer_ping
branch
from
c38ad21
to
216e048
Compare
maximiliankolb
approved these changes
Oct 4, 2024
|
I'm going to cherry pick this down to 3.5 after all. I happen to have the right VM at hand just now so I was able to verify the output for all the versions too. |
Or not! Because the Hammer guide doesn't exist prior to 3.12. |
asteflova
added a commit
that referenced
this pull request
Oct 4, 2024
(cherry picked from commit 507edce)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Updating the example output of
hammer ping.Why are you introducing these changes? (Explanation, links to references, issues, etc.)
As reported in https://issues.redhat.com/browse/SAT-28362, the output of hammer ping in the most recent versions differs significantly from what we currently document.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
I'm requesting cherry-picks down to 3.9 only because I currently don't have any test environments for the earlier versions. Considering that we're only talking about example CLI output, I think these cherry picks are enough, but if anyone disagrees, I can check all the other supported versions too.Checklists
Please cherry-pick my commits into: