Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing step to update RHSM cert #3342

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Add missing step to update RHSM cert #3342

merged 1 commit into from
Oct 7, 2024

Conversation

Lennonka
Copy link
Contributor

@Lennonka Lennonka commented Oct 2, 2024

What changes are you introducing?

Adding missing step to update the CA cert in RHSM config

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

https://issues.redhat.com/browse/SAT-28431

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Follow-up on #3193

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • We do not accept PRs for Foreman older than 3.5.

@Lennonka Lennonka added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective labels Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

The PR preview for 2802ce4 is available at theforeman-foreman-documentation-preview-pr-3342.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

asteflova
asteflova approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@asteflova asteflova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay style-wise.

@Lennonka Lennonka added style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective and removed Needs style review Requires a review from docs style/grammar perspective Needs tech review Requires a review from the technical perspective labels Oct 2, 2024
@Lennonka
Copy link
Contributor Author

Lennonka commented Oct 3, 2024 •
edited
Loading

I've set the tech review done because the ca_registration.erb snippet that is used in the automated variants of these procedures updates the RHSM certificate as well. These changes are based on this fact.

@ShimShtein
Copy link
Member

ACK, makes sense to me

@Lennonka Lennonka merged commit f50e6b3 into theforeman:master Oct 7, 2024
9 checks passed
@Lennonka
Copy link
Contributor Author

Lennonka commented Oct 7, 2024

Cherry-picked:

@Lennonka Lennonka deleted the add-missing-step-deploying-ca-cert-manually branch October 7, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteflova asteflova asteflova approved these changes

@maximiliankolb maximiliankolb maximiliankolb approved these changes

Assignees
No one assigned
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lennonka @ShimShtein @maximiliankolb @asteflova