Turn chronyd module into a short prerequisite #3345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asteflova
force-pushed
the
SAT-27943_time_sync
branch
from
566eacd
to
8895f0e
Compare
asteflova
force-pushed
the
SAT-27943_time_sync
branch
from
8895f0e
to
10f1c15
Compare
asteflova
added
Needs tech review
asteflova
commented
Oct 3, 2024
maximiliankolb
added
style review done
evgeni
reviewed
Oct 4, 2024
evgeni
reviewed
Oct 4, 2024
asteflova
commented
Oct 4, 2024
asteflova
force-pushed
the
SAT-27943_time_sync
branch
from
2f37f15
to
aa9d42f
Compare
maximiliankolb
approved these changes
Oct 4, 2024
evgeni
approved these changes
Oct 4, 2024
asteflova
added
tech review done
asteflova
added a commit
that referenced
this pull request
Oct 4, 2024
The prerequisite avoids mentioning any specific timekeeping protocol (previously: NTP) or service (previously: chronyd) because these are not the only options. (cherry picked from commit f21fc89)
asteflova
added a commit
to asteflova/foreman-documentation
that referenced
this pull request
Nov 1, 2024
The prerequisite avoids mentioning any specific timekeeping protocol (previously: NTP) or service (previously: chronyd) because these are not the only options. (cherry picked from commit f21fc89)
This was referenced Nov 1, 2024
asteflova
added a commit
to asteflova/foreman-documentation
that referenced
this pull request
Nov 4, 2024
The prerequisite avoids mentioning any specific timekeeping protocol (previously: NTP) or service (previously: chronyd) because these are not the only options. (cherry picked from commit f21fc89)
10 tasks
asteflova
added a commit
to asteflova/foreman-documentation
that referenced
this pull request
Nov 7, 2024
The prerequisite avoids mentioning any specific timekeeping protocol (previously: NTP) or service (previously: chronyd) because these are not the only options. (cherry picked from commit f21fc89)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Dropping the module to configure chronyd and replacing it with a short prerequisite.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
chronyd is installed and enabled by default, a short prerequisite is enough. See also https://issues.redhat.com/browse/SAT-27943
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
This PR also removes the module on clock sync from Configuring Load Balancing. I don't think that's a problem because the assembly in that guide links to Installing Proxy where the new prerequisite is listed.
Checklists
Please cherry-pick my commits into: