-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow use of foreman-installer PR #1208
base: master
Are you sure you want to change the base?
Conversation
c3ef216
to
8e50756
Compare
236be57
to
dd91ebd
Compare
@ekohl I updated this to truly skip RPM installation and install foreman-installer and all puppet modules from source using librarian-puppet. Any idea how I could properly handle the SCL ruby version? |
I also need to figure out what is different w.r.t. answers files vs. RPM installation and ensure the right executable gets called. |
dd91ebd
to
5f32fea
Compare
With my latest work on this, I have it working to build the installer from source (haven't fully implemented using a PR number yet) and running the installer which fails due to:
|
Now getting through all hooks up to puppet apply, where it fails due to:
|
5f32fea
to
96cf951
Compare
Installing puppet-agent fixed the issue: |
96cf951
to
7d85d48
Compare
Pushed another update. I'm sticking with SCLs but had to apply a few workarounds. I'm setting up the puppetserver ca before running the installer (because it doesn't work when the installer tries to do it in the SCL context) I had to edit the Gemfile as well to install some additional dependencies. There is still an issue getting rh-redis5-redis.service to start. Looks like a permissions issue with /var/log/redis/redis.log but the obvious change didn't resolve it in my test environment. I will investigate that more later. |
7d85d48
to
c33a35c
Compare
- name: "build installer from source when installer PR is specified" | ||
set_fact: | ||
foreman_installer_from_source: True | ||
when: foreman_installer_git_pr_number is defined and foreman_installer_git_pr_number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ehelms This should provide the functionality you requested.
This is a very rough draft of an idea to use a foreman-installer PR with forklift
Actually currently it allows any fork and branch to be used, but could be updated to specify a PR number instead
The RPM is still installed but we are doing
git checkout -f
over it which is kind of hackish but I need to figure out a strategy to deal with themodules/
subdirectory.