Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CentOS Stream 9 provisioning using theforeman.foreman modules #1856

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Add CentOS Stream 9 provisioning using theforeman.foreman modules #1856

merged 1 commit into from
Sep 20, 2024

Conversation

archanaserver
Copy link
Contributor

@archanaserver archanaserver commented Sep 10, 2024 •
edited
Loading

This PR rewrite the CentOS Stream 9 provisioning tasks by replacing
Hammer CLI commands with theforeman.foreman modules.

For reference: #1832 (comment)

@archanaserver
Copy link
Contributor Author

@evgeni #1856 I have raised the changes here, but can't run the task due to weird syntax error, how can i test this? I don't see any syntax error

The error appears to be in '/home/akumari/Desktop/theforeman/forklift/roles/foreman_provisioning/tasks/configure_centos_9.yml': line 1, column 3, but may be elsewhere in the file depending on the exact syntax problem.

@archanaserver archanaserver mentioned this pull request Sep 10, 2024
Merged
@archanaserver archanaserver force-pushed the refactor-centos-provisioning-theforeman branch from c08b8e7 to e21d2ad Compare September 16, 2024 08:37
@ekohl
Copy link
Member

ekohl commented Sep 16, 2024

This would be a bit easier to review if the centos7 and centos8 boxes name update commit wasn't in here.

@archanaserver archanaserver force-pushed the refactor-centos-provisioning-theforeman branch 2 times, most recently from 5e5f4aa to db7ad78 Compare September 18, 2024 07:14
evgeni
evgeni reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR/commit should be called "add CentOS Stream 9 provisioning using theforeman.foreman modules" now -- you're not refactoring anything as such.

(and then the other PR drops the 7/8 stuff)

roles/foreman_provisioning/tasks/configure_centos_9.yml Show resolved Hide resolved
@archanaserver archanaserver changed the title Refactor CentOS provisioning to use theforeman.foreman modules Add CentOS Stream 9 provisioning using theforeman.foreman modules Sep 19, 2024
@archanaserver archanaserver force-pushed the refactor-centos-provisioning-theforeman branch from db7ad78 to 9f12d3b Compare September 19, 2024 21:21
@archanaserver
Add CentOS Stream 9 provisioning using theforeman.foreman modules
84fe734 
This PR refactors the CentOS Stream 9 provisioning tasks by replacing
Hammer CLI commands with theforeman.foreman Ansible modules.
@archanaserver archanaserver force-pushed the refactor-centos-provisioning-theforeman branch from 9f12d3b to 84fe734 Compare September 19, 2024 21:23
@evgeni evgeni merged commit 5592157 into theforeman:master Sep 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@evgeni evgeni evgeni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@archanaserver @ekohl @evgeni