Fixes #37604 - Validate DNS forwarders #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user can input an invalid value and the service will refuse to start up. We can catch this in data types, preventing service downtime.
ehelms
approved these changes
Jun 27, 2024
evgeni
approved these changes
Jun 28, 2024
Comment on lines
+6
to
+11
| type Dns::Forwarder = Variant[ | ||
| Pattern[/\A([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])(\.([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])){3}(\s+port\s+[0-9]{1,5})?\z/], | ||
| Stdlib::IP::Address::V6::Nosubnet, | ||
| # This is a really gross simplification of IPv6 | ||
| Pattern[/(\A(:{0,2}[[:xdigit:]]{1,4}){1,8}\s+port\s[0-9]{1,5}\Z)/], | ||
| ] |
There was a problem hiding this comment.
Technically, it can also be <ip> port <int> tls <name> and similar:
https://bind9.readthedocs.io/en/latest/reference.html#namedconf-statement-forwarders
Well, at least since 9.19.10: https://bind9.readthedocs.io/en/v9.19.10/notes.html#new-features
I don't think we need to care right now, but in the future
There was a problem hiding this comment.
I didn't see that in man named.conf on Fedora 39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user can input an invalid value and the service will refuse to start up. We can catch this in data types, preventing service downtime.