Fixes #36645 - Change the default Redis cache DB to 4 #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like that! |
|
What was the issue with using |
|
PCP is also using 0 by default |
ekohl
force-pushed
the
other-default-redis-db
branch
from
a43bf3b
to
29c15f1
Compare
On a typical Katello installation Dynflow uses DB 6 and Pulp uses DB 8. Other applications may also use the default DB. Using DB 4 should not conflict. Fixes: dfa6a86 ("Fixes #36037 - Manage Redis service for Redis cache")
ekohl
force-pushed
the
other-default-redis-db
branch
from
29c15f1
to
47136ea
Compare
ekohl
changed the title
|
Now with a Redmine issue for a changelog entry. |
evgeni
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a typical Katello installation Dynflow uses DB 6 and Pulp uses DB 8. Other applications may also use the default DB. Using DB 4 should not conflict.
@evgeni this is something you raised yesterday.
This probably deserves a release note. We should also consider cleaning up the old DB. By default Redis is configured for persistence so it should remain even after a restart. According to the internet using
redis-cli -n 0 flushdbshould do that. I don't think it's something we want to do automatically. If users don't do this, they will expire eventually anyway and the cache is not that large.