Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #33590 - Support multiple DNS domains #705

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Sep 29, 2021

This changes the dns_zone option from an optional string to an array which allows creating multiple zones. For compatibility it still supports the single string and undef options. In a major release this should be changed to only accept an array.

This changes the dns_zone option from an optional string to an array
which allows creating multiple zones. For compatibility it still
supports the single string and undef options. In a major release this
should be changed to only accept an array.
@evgeni
Copy link
Member

evgeni commented Sep 29, 2021

        expected that the catalogue would contain Class[foreman_proxy::proxydns] with forward_zone set to "example.com" but it is set to ["example.com"]

seems some tests still need adjustment, but overall 👍

@ekohl
Copy link
Member Author

ekohl commented Sep 29, 2021

One thing I just realized is that this will also create entries for the @soa but those will be out of the zone. That needs a bit more thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants