Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add faraday-retry to Gemfile #2150

Closed
wants to merge 1 commit into from
Closed

Conversation

bastelfreak
Copy link
Member

It's an optional dependency of octokit. Without it we always get a warning on the CLI:

To use retry middleware with Faraday v2.0+, install `faraday-retry` gem

It's an optional dependency of octokit. Without it we always get a
warning on the CLI:

```
To use retry middleware with Faraday v2.0+, install `faraday-retry` gem
```
@evgeni
Copy link
Member

evgeni commented Jun 29, 2024

But we're not using octokit, so why pulling in another dep?

@bastelfreak
Copy link
Member Author

octokit is a dependency of github-pages-health-check, jekyll-gist and jekyll-github-metadata. octokit by default uses faraday which in turn wants to use faraday-retry and complains when it's missing. It's a bit of a rabbithole :( At Vox Pupuli we've the same issue with the github_changelog_generator that also pulls in octokit => faraday => faraday-retry. That's why we added faraday-retry there as well.

@evgeni
Copy link
Member

evgeni commented Jun 30, 2024

I know. But we're still not actively using any of that, so I see no reason to add another dependency just to silence that warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants