3.12 update installer options #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Sep 12, 2024
| @@ -341,7 +350,7 @@ kafo-export-params -c /etc/foreman-installer/scenarios.d/foreman.yaml -f html | |||
| </tr> | |||
| <tr> | |||
| <td style='white-space:nowrap'>--apache-mod-status-requires</td> | |||
| <td>A Variant type that can be: - String with: - '' or 'unmanaged' - Host auth control done elsewhere - 'ip <List of IPs>>' - Allowed IPs/ranges - 'host <List of names>' - Allowed names/domains - 'all [granted|denied]' - Array of strings with ip or host as above - Hash with following keys: - 'requires' - Value => Array as above - 'enforce' - Value => String 'Any', 'All' or 'None' This encloses "Require" directives in "<Require(Any|All|None)>" block Optional - If unspecified, "Require" directives follow current flow</td> | |||
| <td>A Variant type that can be: - String with: - '' or 'unmanaged' - Host auth control done elsewhere - 'ip <List of IPs>' - Allowed IPs/ranges - 'host <List of names>' - Allowed names/domains - 'all [granted|denied]' - Array of strings with ip or host as above - Hash with following keys: - 'requires' - Value => Array as above - 'enforce' - Value => String 'Any', 'All' or 'None' This encloses "Require" directives in "<Require(Any|All|None)>" block Optional - If unspecified, "Require" directives follow current flow</td> | |||
There was a problem hiding this comment.
Oh yes, this was the issue with escaping which the script didn't do. Though it surprises me we didn't need to escape the < and > in Require. HTML can probably deal with it because of the weird tags in between. Please keep this as it was.
| @@ -2519,6 +2548,7 @@ kafo-export-params -c /etc/foreman-installer/scenarios.d/foreman.yaml -f html | |||
| </table> | |||
| </div> | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Nit: redundant empty line
Suggested change
| @@ -317,6 +325,7 @@ More information about compute resources can be found in the [Compute Resources | |||
| </table> | |||
| </div> | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Nit: redundant empty line
Suggested change
ekohl
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.