Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak CSS #857

Merged
merged 9 commits into from
Dec 16, 2023
Merged

Tweak CSS #857

merged 9 commits into from
Dec 16, 2023

Conversation

taras
Copy link
Member

@taras taras commented Dec 15, 2023

Motivation

Make it look better

Approach

  1. Made footer show up under article
  2. Made footer smaller
  3. Adding padding between sections
  4. Made TOC wrap

Alternate Designs

Possible Drawbacks or Risks

TODOs and Open Questions

Learning

Screenshots

@taras taras requested a review from cowboyd December 15, 2023 23:08
@cowboyd
Copy link
Member

cowboyd commented Dec 16, 2023

I'm going to go ahead and approve because CSS is really, really difficult to get right and you can fall down a rabbit hole of reorganizing page structure, but we do need to revisit the footer since it isn't really a footer anymore.

image

In order to match with the page footer it should:

  1. span all content on the page
  2. appear on every page

@taras taras merged commit d89f25a into v3 Dec 16, 2023
1 check passed
@taras taras deleted the tm/tweak-css branch December 16, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants