Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📄 Fix documentation on streams and subscriptions #866

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

cowboyd
Copy link
Member

@cowboyd cowboyd commented Dec 19, 2023

Motivation

The docs on subscriptions used the old subscribe() API

Approach

  • Fix the API error
  • fix some formatting issues
  • apply @bdougherty's suggestion of connecting the example resource to the on() function.

Preview

The docs on subscriptions used the old API, and could be improved by
linking to the section on events.
@cowboyd cowboyd requested a review from a team December 19, 2023 16:01
@cowboyd cowboyd merged commit fa5cf8a into v3 Dec 19, 2023
1 check passed
@cowboyd cowboyd deleted the fix-collection-docs branch December 19, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants