Fix serverside hologram position getting set to origin when parented

[thegrb93]

Fixes: #1974

[thegrb93]

@adamnejm do you know how to test if the original thing this was fixing isn't an issue now?

I think it was something to do with clientside holograms not keeping their offset?

[adamnejm]

Yeah, the repro code is in #1407, it used to just set position of the little holograms to the parent hologram, without keeping the offset.

If the code from #1407 just shifts the entire thing keeping offsets between holos, that means it works. If anything else happens that means it's broken.

[adamnejm]

Yeah, I reverted to a commit before ac0a3bb and still cannot reproduce it, so pretty sure it got fixed by an update.

[thegrb93]

@adamnejm for me, all the child holos get sent to the center of the parent, which seems wrong.

[adamnejm]

That's weird, for me they keep the offset which is the correct behavior.
I also just tested the Windows version of the game (albeit using Wine on Linux) and it works fine too.

[adamnejm]

OK, I can reproduce it on 32-bit branch Linux version. Not 64-bit tho.

[thegrb93]

great, so its behavior varies by gmod branch.

[Cheatoid]

Varies by OS, branch and singleplayer/multiplayer? That's some cursed conditionals!
I am on non-beta 32-bit branch, windows, singleplayer. Should make chart/grid...

[thegrb93]

Just branch and sp/mp I'm pretty sure.

[adamnejm]

After more testing, I determined that the fix is to only apply the workaround to clientside holograms. Duh... it should've been like that from the beginning :D

if self:EntIndex() == -1 then
    self:SetParent(Entity(0))
    self:SetParent()
end

After that, everything works perfectly. Tested multiplayer and singleplayer on 32-bit and 64-bit.

[adamnejm]

PS. This also fixes holo:getRight() returning 0,0,0. Didn't test similar functions, but please include some info about that in the hack comment.
Certified Garry Moment.

[adamnejm]

Also while the fix is not needed on 64-bit, I'd just leave it in instead of doing branch checking, it doesn't have any negative side-effects.

[thegrb93]

Ahhh nice discovery