Draft - update dependencies to support building development environment on OS X #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes failing builds on os X
|
|
mrchrisadams
changed the title
This time being explicit about python version, like so python -m pipenv lock --dev --clear --python 3.8.10 python -m pipenv install --dev --clear --python 3.8.10
|
At least. With pipenv, I think you need to be really careful when setting up a virtualenv. This didn't give me the virtual env using python 3.8.10, no matter what I did with switching local pythons, and even making it explicit in the pipfile doesn't seemt to work. I had to do this when creating the virtual environment instead: |
|
This is no longer needed - we addressed the problematic mysqlclient dependency issue in a recent PR instead linked below: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tightens up the specified version of
mysqlclientthat was causing failing builds on OS X, which meant working without gitpod locally was impossible.It also moves the
richlogging library into thepackagesgroup. It's useful in management commands, as well as logging generally.