Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

Haskell Installation for Theia-Full #479

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lapplislazuli
Copy link

Hi there,

as shortly discussed in #478,
I added steps necessary to install Haskell and primary build-tools to theia-full-docker.
That is

  • GHC (the compiler)
  • Cabal (Similar to Java's maven)
  • Stack (Maven+Virtual Environments per Project)
  • GHCup (Small helper to keep everything up to date).

I tried specify the versions with Args and defaulted them to current latest.

I also (for myself) have a small repo where I have it similar to the theia-cpp-docker, if you'd prefer it contributed as another separate image.

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lapplislazuli thank you for the contribution, please be sure to add a sign-off to your commit so it passes the DCO check 👍

I noticed you updated the environment and built tools for haskell support, shouldn't we also add a corresponding extension? (ex: https://open-vsx.org/extension/haskell/haskell)

@lapplislazuli
Copy link
Author

@vince-fugnitto Thanks for the quick answer, I added the signoff 😄
I think that would be a good remark in the CONTRIBUTING.md

I think the Haskell Extension would be great - but I must admit I have no clue how to add it.

@vince-fugnitto
Copy link
Member

I think that would be a good remark in the CONTRIBUTING.md

I thought it was there, but maybe it's only for the main eclipse theia repository:

We can definitely add it :)

I think the Haskell Extension would be great - but I must admit I have no clue how to add it.

You simply need to reference the extension at a compatible version in the latest.package.json and next.package.json like so:

"vscode-go": "https://open-vsx.org/api/golang/Go/0.16.2/file/golang.Go-0.16.2.vsix",

"vscode-go": "https://open-vsx.org/api/golang/Go/0.16.2/file/golang.Go-0.16.2.vsix",

The extensions listed as part of the application are bundled and readily available for all users using the application.

The version 1.2.0 should be API compatible (based on it's engines.vscode).
The framework currently supports an API of 1.50,0.

Please be sure that the requirements are met in the actual dockerfile: https://open-vsx.org/extension/haskell/haskell#requirements.

@lapplislazuli
Copy link
Author

Hi @vince-fugnitto ,

I have looked around the Haskell Plugins, the "biggest" (and soon-to-be best) plugin is yet in an too early state. I'll keep an eye open for it, but at the moment some of the integration is not done.
I hence added a very lightweight addon that just highlights syntax.

@@ -137,7 +137,8 @@
"vscode-ruby": "https://github.com/rubyide/vscode-ruby/releases/download/v0.25.0/ruby-0.25.0.vsix",
"vscode-dart": "https://github.com/Dart-Code/Dart-Code/releases/download/v3.8.1/Dart-Code.dart-code-3.8.1.vsix",
"vscode-flutter": "https://github.com/Dart-Code/Flutter/releases/download/v3.8.1/Dart-Code.flutter-3.8.1.vsix",
"haskell-syntax-highlighting": "https://open-vsx.org/api/justusadam/language-haskell/3.3.0/file/justusadam.language-haskell-3.3.0.vsix",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License looks good: BSD-3-Clause 👍

@stale
Copy link

stale bot commented Jul 31, 2021

This contribution has been automatically marked as stale due to inactivity, and it will be closed if no further activity occurs. Thank you for contributing to Theia!

@stale stale bot added the stale label Jul 31, 2021
@stale stale bot removed the stale label Aug 2, 2021
@marcdumais-work
Copy link
Member

Hi @lapplislazuli ,

Sorry, thie PR fell through the cracks. Do you know if the Haskell extension you mention has been improved since May? If you, maybe you could add it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants