-
Notifications
You must be signed in to change notification settings - Fork 345
Haskell Installation for Theia-Full #479
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lapplislazuli thank you for the contribution, please be sure to add a sign-off
to your commit so it passes the DCO
check 👍
I noticed you updated the environment and built tools for haskell
support, shouldn't we also add a corresponding extension? (ex: https://open-vsx.org/extension/haskell/haskell)
Signed-off-by: Leonhard Applis <[email protected]>
@vince-fugnitto Thanks for the quick answer, I added the signoff 😄 I think the Haskell Extension would be great - but I must admit I have no clue how to add it. |
I thought it was there, but maybe it's only for the main We can definitely add it :)
You simply need to reference the extension at a compatible version in the
The extensions listed as part of the application are bundled and readily available for all users using the application. The version Please be sure that the requirements are met in the actual dockerfile: https://open-vsx.org/extension/haskell/haskell#requirements. |
Signed-off-by: lapplislazuli <[email protected]>
Hi @vince-fugnitto , I have looked around the Haskell Plugins, the "biggest" (and soon-to-be best) plugin is yet in an too early state. I'll keep an eye open for it, but at the moment some of the integration is not done. |
@@ -137,7 +137,8 @@ | |||
"vscode-ruby": "https://github.com/rubyide/vscode-ruby/releases/download/v0.25.0/ruby-0.25.0.vsix", | |||
"vscode-dart": "https://github.com/Dart-Code/Dart-Code/releases/download/v3.8.1/Dart-Code.dart-code-3.8.1.vsix", | |||
"vscode-flutter": "https://github.com/Dart-Code/Flutter/releases/download/v3.8.1/Dart-Code.flutter-3.8.1.vsix", | |||
"haskell-syntax-highlighting": "https://open-vsx.org/api/justusadam/language-haskell/3.3.0/file/justusadam.language-haskell-3.3.0.vsix", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
License looks good: BSD-3-Clause 👍
This contribution has been automatically marked as stale due to inactivity, and it will be closed if no further activity occurs. Thank you for contributing to Theia! |
Hi @lapplislazuli , Sorry, thie PR fell through the cracks. Do you know if the Haskell extension you mention has been improved since May? If you, maybe you could add it? |
Hi there,
as shortly discussed in #478,
I added steps necessary to install Haskell and primary build-tools to theia-full-docker.
That is
I tried specify the versions with Args and defaulted them to current latest.
I also (for myself) have a small repo where I have it similar to the theia-cpp-docker, if you'd prefer it contributed as another separate image.