Skip to content

Commit

Permalink
chore(docker): Update container build issues after other refactoring
Browse files Browse the repository at this point in the history
  • Loading branch information
alerque committed Aug 28, 2024
1 parent dded08d commit 157cd7f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
5 changes: 2 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,7 @@ RUN make
RUN make check-version
RUN make install DESTDIR=/pkgdir

# Work around BuiltKit / buildx bug, they can’t copy to symlinks only dirs
RUN mv /pkgdir/usr/local/{share/,}/man
FROM base AS final

# Same args as above, repeated because they went out of scope with FROM
ARG REVISION
Expand Down Expand Up @@ -107,4 +106,4 @@ COPY --from=builder /src/lib/fontship-entry.zsh /usr/local/bin
RUN fontship --version

WORKDIR /data
ENTRYPOINT ["fontship-entry.zsh"]
ENTRYPOINT [ "fontship-entry.zsh" ]
5 changes: 3 additions & 2 deletions hooks/build
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ set -e

: "${ARCHTAG:=latest}"

DESC=$(git describe --long --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g')
REVISION=$(git describe --long --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g')

RUNTIME_DEPS='diffutils entr font-v gftools git libarchive libgit2 make'\
' psautohint python python-babelfont python-brotli python-cffsubr'\
Expand All @@ -18,7 +18,8 @@ export DOCKER_BUILDKIT

docker build \
--build-arg ARCHTAG="$ARCHTAG" \
--build-arg VCS_REF="${1:-$DESC}" \
--build-arg REVISION="$REVISION" \
--build-arg VERSION="${1:-$REVISION}" \
--build-arg RUNTIME_DEPS="$RUNTIME_DEPS" \
--build-arg BUILD_DEPS="$BUILD_DEPS" \
--tag $DOCKER_REPO:$DOCKER_TAG \
Expand Down

0 comments on commit 157cd7f

Please sign in to comment.