Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Muse & Mist] Footer is not at the bottom of the page when the sidebar display is removed #1718

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

egandx
Copy link

@egandx egandx commented Nov 15, 2022

PR Checklist

  • The commit message follows guidelines for NexT.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.(Sidebar display only for Muse|Mist)
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build & CI related changes.
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

Configuration info:
Next version: 7.8.0 (Current latest version)
Scheme: Mist & Muse

When sidebar display is removed,footer is not at the bottom of the page.

2022-11-15 08 40 41

What is the new behavior?

when CONFIG.sidebar.display === 'remove', not adjusting the position of the sidebar

2022-11-15 10 39 27

@welcome
Copy link

welcome bot commented Nov 15, 2022

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


“egandx” seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants