-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ThemeService.$theme doesn't update #58
Comments
Hello there, |
Hi @MGREMY, thanks for your response. Looks like v1 is a major update with many breaking changes. Looks like in v1:
could you please point me in the right direction regarding how to implement theme switching (dark/light) in v1? Thanks |
To clarify the comment above, what I'd like to know is how to 'subscribe' to theme changes so I can update another third-party component (AgGrid) based on the current theme. |
Hey We will have some adjustments to make of dark/light theme, but if you want to add dark/light theme into your application, you just have to add somewhere the |
For now we don't provide a way to subscribe or get the signal of the current theme For now, one solution could be to subscribe to the localStorage's |
Ok, thank you @MGREMY , will use localStorage for now. Will be waiting for the 'official' way Service/Observable/Signal. |
Hey @mruknowme |
Hi @MGREMY, great, thank you! Will check it out in next couple of days when back to the project that uses angular-flowbite and let you know. Keep up the great work! 👍🏼 |
It's not released yet tho, it's still on the 1.1.0 branch if you want to see it 🙂 |
Hi @MGREMY , noticed that |
Hey @mruknowme, |
Hey @mruknowme |
I'm closing this as there's no update |
ThemeService.$theme doesn't update when the theme is switched using the switcher component.
The text was updated successfully, but these errors were encountered: