Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] DarkThemeToggle - Provide an API for current theme value #82

Closed
MGREMY opened this issue Nov 23, 2024 · 1 comment
Closed

[Feature] DarkThemeToggle - Provide an API for current theme value #82

MGREMY opened this issue Nov 23, 2024 · 1 comment
Assignees
@MGREMY
Labels
enhancement New feature or request

Comments

@MGREMY
Copy link
Collaborator

MGREMY commented Nov 23, 2024 •
edited
Loading

Description

Provide a clean API to access the current theme.
Linked to #58

Proposed solution

Provide a top-level directive used in the body tag of the page, which is keeping the current theme value. This Directive could have an opened API to access the current theme value. It could provide an API to toggle the current theme and so on.

Alternatives considered

No response
@MGREMY MGREMY added the enhancement New feature or request label Nov 23, 2024
@MGREMY MGREMY self-assigned this Nov 23, 2024
@MGREMY MGREMY moved this to Backlog in Flowbite Angular Library Nov 23, 2024
@MGREMY MGREMY moved this from Ready to In progress in Flowbite Angular Library Dec 3, 2024
MGREMY added a commit that referenced this issue Dec 3, 2024
@MGREMY
feat(theme): add clean api to access and modify the current applicati…
906a894 
…on theme #82
MGREMY added a commit that referenced this issue Dec 3, 2024
@MGREMY
docs(theme): fix doc #82
8509bd1
@MGREMY MGREMY moved this from In progress to In review in Flowbite Angular Library Dec 3, 2024
@MGREMY MGREMY mentioned this issue Dec 5, 2024
Closed
MGREMY added a commit that referenced this issue Dec 5, 2024
@MGREMY
feat(theme): add signal based accessor to current theme #82
90807d3
@MGREMY MGREMY mentioned this issue Dec 11, 2024
Merged
11 tasks
MGREMY added a commit that referenced this issue Dec 11, 2024
@MGREMY
1.1.0 (#88)
b23f020 
## PR Checklist

Please check if your PR fulfills the following requirements:

<!--- [ ] Tests for the changes have been added (for bug
fixes/features)-->

- [x] Docs have been added/updated (for bug fixes/features)

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [x] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no API changes)
- [ ] Build related changes
- [ ] CI-related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## Issue Number

<!-- Bugs and features must be linked to an issue. -->

Issue Number: #80 #82 

## Does this PR introduce a breaking change?

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

- [ ] Yes
- [x] No

## Other information

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a `FlowbiteThemeDirective` for managing application themes
with local storage support.
- Added support for dark mode customization and documentation.
- New components and features for dropdowns, accordions, alerts, badges,
breadcrumbs, buttons, modals, sidebars, and navigation bars with
enhanced configurability through dependency injection.

- **Documentation**
- Updated documentation for dark mode, component customization, and
theme management.

- **Bug Fixes**
- Removed redundant verification methods across various components to
streamline functionality.

- **Chores**
- Added new files and updated paths for better module resolution in
TypeScript.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
MGREMY pushed a commit that referenced this issue Dec 11, 2024
@semantic-release-bot
chore(flowbite-angular): 1.1.0 [skip ci]
5714619 
# [1.1.0](https://github.com/themesberg/flowbite-angular/compare/[email protected]@v1.1.0) (2024-12-11)

### Bug Fixes

* **dropdown:** set container's min-width ([a9e19d5](a9e19d5))

### Features

* **accordion:** add animation ([7e92417](7e92417))
* **accordion:** provide injection token for default input value [#80](#80) ([04f4d54](04f4d54))
* **alert:** add animation ([84d0c53](84d0c53))
* **alert:** provide injection token for default input value [#80](#80) ([da3ff4a](da3ff4a))
* **badge:** provide injection token for default input value [#80](#80) ([f7337d6](f7337d6))
* **breadcrumb:** provide injection token for default input value [#80](#80) ([f8b0f20](f8b0f20))
* **button:** provide injection token for default input value [#80](#80) ([9d8d700](9d8d700))
* **dark-theme-toggle:** provide injection token for default input value [#80](#80) ([f4c5854](f4c5854))
* **dropdown:** provide injection token for default input value [#80](#80) ([bbda81d](bbda81d))
* **dropdown:** use `viewChield()`, remove position calculation ([5394931](5394931))
* **dropdown:** use `viewChield()`, remove position calculation ([114c9d1](114c9d1))
* **dropdown:** use tailwind classes instead of @floating-ui/dom ([1d4c0dc](1d4c0dc))
* **dropdown:** use tailwind classes instead of @floating-ui/dom ([1f0b871](1f0b871))
* **indicator:** provide injection token for default input value [#80](#80) ([cbaca0f](cbaca0f))
* **indicator:** provide injection token for default input value [#80](#80) ([cdbb78c](cdbb78c))
* **modal:** provide injection token for default input value [#80](#80) ([4463716](4463716))
* **navbar:** add animation ([5df1c2d](5df1c2d))
* **navbar:** provide injection token for default input value [#80](#80) ([fab0fbb](fab0fbb))
* **scroll-top:** provide injection token for default input value [#80](#80) ([02b9e21](02b9e21))
* **sidebar:** provide injection token for default input value [#80](#80) ([6d57117](6d57117))
* **theme:** add clean api to access and modify the current application theme [#82](#82) ([906a894](906a894))
* **theme:** add signal based accessor to current theme [#82](#82) ([90807d3](90807d3))
@MGREMY
Copy link
Collaborator Author

MGREMY commented Dec 11, 2024

Available in 1.1.0

@MGREMY MGREMY closed this as completed Dec 11, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Flowbite Angular Library Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MGREMY MGREMY

Labels
enhancement New feature or request
Projects
Flowbite Angular Library
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MGREMY