Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course slug is now update-able 🎉 #549

Closed
wants to merge 5 commits into from
Closed

Course slug is now update-able 🎉 #549

wants to merge 5 commits into from

Conversation

shewa12
Copy link
Collaborator

@shewa12 shewa12 commented Sep 7, 2023

No description provided.

@shewa12 shewa12 changed the base branch from master to dev September 7, 2023 05:35
Copy link

@bernhardkaindl bernhardkaindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shewa12 It looks like this should have been merged into 2.3.0 before release to update the course slug in the permalinks of the courses!

PS: The same update of the lesson permalinks seems to be missing when changing the lession_permalink_base!!!

Copy link

@bernhardkaindl bernhardkaindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shewa12: See #564, where I rebased this PR to the current dev (resolved the conflicts)

@shewa12 shewa12 closed this Sep 28, 2023
@shewa12 shewa12 deleted the course-slug branch December 18, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants